Changeset 107117 in vbox

Timestamp:

Nov 22, 2024 11:17:47 AM (8 weeks ago)

Author:

vboxsync

Message:

VMM: bugref:10759 APIC restructure [doxygen fixes]

Location:

trunk

Files:

• include/VBox/vmm/pdmapic.h (modified) (10 diffs)
• src/VBox/VMM/VMMAll/APICAll.cpp (modified) (3 diffs)
• src/VBox/VMM/VMMAll/PDMAllApic.cpp (modified) (2 diffs)

trunk/include/VBox/vmm/pdmapic.h

@@ -215 +215 @@
      * @param   pVCpu                   The cross context virtual CPU structure.
      * @param   u8Tpr                   The TPR value to set.
-     * @param   fForceX2ApicBehavior    Pretend the APIC is in x2APIC mode during
-     *                                  this write.
+     * @param   fForceX2ApicBehaviour   Pretend the APIC is in x2APIC mode during this
+     *                                  write.
      */
     DECLR3CALLBACKMEMBER(int, pfnSetTpr, (PVMCPUCC pVCpu, uint8_t u8Tpr, bool fForceX2ApicBehaviour));
@@ -277 +277 @@
      * @param   puSrcTag    Where to store the interrupt source tag (debugging).
      */
-    DECLR3CALLBACKMEMBER(int, pfnGetInterrupt, (PVMCPUCC pVCpu, uint8_t *pu8Vector, uint32_t *pu32TagSrc));
+    DECLR3CALLBACKMEMBER(int, pfnGetInterrupt, (PVMCPUCC pVCpu, uint8_t *pu8Vector, uint32_t *puSrcTag));
 
     /**
@@ -321 +321 @@
      */
     DECLR3CALLBACKMEMBER(int, pfnBusDeliver, (PVMCC pVM, uint8_t uDest, uint8_t uDestMode, uint8_t uDeliveryMode, uint8_t uVector,
-                                              uint8_t uPolarity, uint8_t uTriggerMode, uint32_t uTagSrc));
+                                              uint8_t uPolarity, uint8_t uTriggerMode, uint32_t uSrcTag));
 
     /**
@@ -463 +463 @@
      * @param   pVCpu                   The cross context virtual CPU structure.
      * @param   u8Tpr                   The TPR value to set.
-     * @param   fForceX2ApicBehavior    Pretend the APIC is in x2APIC mode during
-     *                                  this write.
+     * @param   fForceX2ApicBehaviour   Pretend the APIC is in x2APIC mode during this
+     *                                  write.
      */
     DECLR0CALLBACKMEMBER(int, pfnSetTpr, (PVMCPUCC pVCpu, uint8_t u8Tpr, bool fForceX2ApicBehaviour));
@@ -525 +525 @@
      * @param   puSrcTag    Where to store the interrupt source tag (debugging).
      */
-    DECLR0CALLBACKMEMBER(int, pfnGetInterrupt, (PVMCPUCC pVCpu, uint8_t *pu8Vector, uint32_t *pu32TagSrc));
+    DECLR0CALLBACKMEMBER(int, pfnGetInterrupt, (PVMCPUCC pVCpu, uint8_t *pu8Vector, uint32_t *puTagSrc));
 
     /**
@@ -569 +569 @@
      */
     DECLR0CALLBACKMEMBER(int, pfnBusDeliver, (PVMCC pVM, uint8_t uDest, uint8_t uDestMode, uint8_t uDeliveryMode, uint8_t uVector,
-                                              uint8_t uPolarity, uint8_t uTriggerMode, uint32_t uTagSrc));
+                                              uint8_t uPolarity, uint8_t uTriggerMode, uint32_t uSrcTag));
 
     /**
@@ -712 +712 @@
      * @param   pVCpu                   The cross context virtual CPU structure.
      * @param   u8Tpr                   The TPR value to set.
-     * @param   fForceX2ApicBehavior    Pretend the APIC is in x2APIC mode during
-     *                                  this write.
+     * @param   fForceX2ApicBehaviour   Pretend the APIC is in x2APIC mode during this
+     *                                  write.
      */
     DECLRGCALLBACKMEMBER(int, pfnSetTpr, (PVMCPUCC pVCpu, uint8_t u8Tpr, bool fForceX2ApicBehaviour));
@@ -774 +774 @@
      * @param   puSrcTag    Where to store the interrupt source tag (debugging).
      */
-    DECLRGCALLBACKMEMBER(int, pfnGetInterrupt, (PVMCPUCC pVCpu, uint8_t *pu8Vector, uint32_t *pu32TagSrc));
+    DECLRGCALLBACKMEMBER(int, pfnGetInterrupt, (PVMCPUCC pVCpu, uint8_t *pu8Vector, uint32_t *puTagSrc));
 
     /**
@@ -818 +818 @@
      */
     DECLRGCALLBACKMEMBER(int, pfnBusDeliver, (PVMCC pVM, uint8_t uDest, uint8_t uDestMode, uint8_t uDeliveryMode, uint8_t uVector,
-                                              uint8_t uPolarity, uint8_t uTriggerMode, uint32_t uTagSrc));
+                                              uint8_t uPolarity, uint8_t uTriggerMode, uint32_t uSrcTag));
 
     /**
@@ -889 +889 @@
 VMM_INT_DECL(VBOXSTRICTRC)  PDMApicGetBaseMsr(PVMCPUCC pVCpu, uint64_t *pu64Value);
 VMM_INT_DECL(int)           PDMApicSetBaseMsr(PVMCPUCC pVCpu, uint64_t u64BaseMsr);
-VMM_INT_DECL(int)           PDMApicGetInterrupt(PVMCPUCC pVCpu, uint8_t *pu8Vector, uint32_t *pu32TagSrc);
+VMM_INT_DECL(int)           PDMApicGetInterrupt(PVMCPUCC pVCpu, uint8_t *pu8Vector, uint32_t *puSrcTag);
 VMM_INT_DECL(int)           PDMApicBusDeliver(PVMCC pVM, uint8_t uDest, uint8_t uDestMode, uint8_t uDeliveryMode, uint8_t uVector,
                                               uint8_t uPolarity, uint8_t uTriggerMode, uint32_t uTagSrc);

trunk/src/VBox/VMM/VMMAll/APICAll.cpp

@@ -417 +417 @@
 
 /**
- * @interface_method_impl{PDMAPICBACKEND,pfnisEnabled}
+ * @interface_method_impl{PDMAPICBACKEND,pfnIsEnabled}
  */
 static DECLCALLBACK(bool) apicIsEnabled(PCVMCPUCC pVCpu)
@@ -457 +457 @@
  *
  * @returns The value at the specified offset.
- * @param   pXApicPage      The xAPIC page.
+ * @param   pVCpu           The cross context virtual CPU structure.
  * @param   offReg          The offset of the register being read.
  */
@@ -3337 +3337 @@
 #ifdef IN_RING0
 /**
- * @interface_method_impl{PDMAPICBACKEND,pfnGetApicPageForCpu}
+ * @interface_method_impl{PDMAPICBACKENDR0,pfnGetApicPageForCpu}
  */
 static DECLCALLBACK(int) apicR0VBoxGetApicPageForCpu(PCVMCPUCC pVCpu, PRTHCPHYS pHCPhys, PRTR0PTR pR0Ptr, PRTR3PTR pR3Ptr)

trunk/src/VBox/VMM/VMMAll/PDMAllApic.cpp

@@ -98 +98 @@
  * @retval  VERR_INVALID_POINTER
  *
- * @param   pVCpu                   The cross context virtual CPU structure.
- * @param   u8Tpr                   The TPR value to set.
- * @param   fForceX2ApicBehaviour   Pretend the APIC is in x2APIC mode during
- *                                  this write.
+ * @param   pVCpu   The cross context virtual CPU structure.
+ * @param   u8Tpr   The TPR value to set.
  */
 VMM_INT_DECL(int) PDMApicSetTpr(PVMCPUCC pVCpu, uint8_t u8Tpr)
@@ -242 +240 @@
  * @param   puSrcTag    Where to store the interrupt source tag (debugging).
  */
-VMM_INT_DECL(int) PDMApicGetInterrupt(PVMCPUCC pVCpu, uint8_t *pu8Vector, uint32_t *pu32TagSrc)
+VMM_INT_DECL(int) PDMApicGetInterrupt(PVMCPUCC pVCpu, uint8_t *pu8Vector, uint32_t *puSrcTag)
 {
     AssertReturn(PDMCPU_TO_APICBACKEND(pVCpu)->pfnGetInterrupt, VERR_INVALID_POINTER);
-    return PDMCPU_TO_APICBACKEND(pVCpu)->pfnGetInterrupt(pVCpu, pu8Vector, pu32TagSrc);
+    return PDMCPU_TO_APICBACKEND(pVCpu)->pfnGetInterrupt(pVCpu, pu8Vector, puSrcTag);
 }