Changeset 107256 in vbox

Timestamp:

Dec 9, 2024 1:15:31 PM (6 weeks ago)

Author:

vboxsync

Message:

bugref:10806. Updated TrackedObjectsCollector::getObj(). jiraref:VBP-1459.

File:

• trunk/src/VBox/Main/src-all/ObjectsTracker.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-all/ObjectsTracker.cpp

@@ -428 +428 @@
 
     IterTrObjData_T pIter = m_trackedObjectsData.find(aObjId);
-    if (pIter != m_trackedObjectsData.end() && fUpdate == true)
-    {
-        /* Update some fields in the found object if needed. in instance, the last access time */
-        com::Utf8Str lat = pIter->second.updateLastAccessTime(); /* Update the access time */
-        Log2(("The updated last access time is %s\n", lat.c_str()));
+    if (pIter != m_trackedObjectsData.end())
+    {
+        if (fUpdate == true)
+        {
+            /* Update some fields in the found object if needed. in instance, the last access time */
+            com::Utf8Str lat = pIter->second.updateLastAccessTime(); /* Update the access time */
+            Log2(("The updated last access time is %s\n", lat.c_str()));
+        }
         hrc = S_OK;
     }
+    else
+        hrc = VBOX_E_OBJECT_NOT_FOUND;
 
     if (SUCCEEDED(hrc))
-    {
-        /** @todo r=bird: Why do three lookups? */
-        if ( i_getObj(aObjId).getInterface().isNotNull() )
-        {
-            if (i_getObj(aObjId).state() != TrackedObjectState_Invalid)
-            {
-                aObjData = i_getObj(aObjId);
-                hrc = S_OK;
-            }
-            else
-                hrc = VBOX_E_INVALID_OBJECT_STATE;
-        }
-        else
-            hrc = VBOX_E_OBJECT_NOT_FOUND;
-    }
+        aObjData = i_getObj(aObjId);
 
     /* Leave critical section here */