Changeset 107273 in vbox

Timestamp:

Dec 10, 2024 10:39:24 AM (7 weeks ago)

Author:

vboxsync

Message:

Windows Additions installer: Touch the installer via the new VBoxNSISTool for verifying + repairing NSIS installer files. This is necessary for getting the CRC32 right after we've built the NSIS installer and set the version via VBoxSetPeVersion afterwards, which renders the initial checksum within the installer invalid and thus prevents starting the installer. bugref:10761

File:

• trunk/src/VBox/Additions/WINNT/Installer/Makefile.kmk (modified) (3 diffs)

trunk/src/VBox/Additions/WINNT/Installer/Makefile.kmk

@@ -249 +249 @@
                 $(VBOX_GA_CERT_ROOT_SHA2_R3) \
                 $(VBOX_GA_CERT_ROOT_SHA2_R3_TS))
+
+# Tool is needed in order to repair the NSIS installer .exe's internal CRC32 checksum
+# after touching it via $(VBOX_PE_SET_VERSION).
+VBOX_NSIS_TOOL := $(PATH_STAGE_BIN)/VBoxNSISTool$(HOSTSUFF_EXE)
 
 VB_WIN_ADD_NSIS_ENV := \
@@ -323 +327 @@
                         '$(subst /,\,$<)'
         $(REDIRECT) -- $(VBOX_PE_SET_VERSION) $@
+        $(REDIRECT) -- $(VBOX_NSIS_TOOL) repair $@
         $(call VBOX_SIGN_IMAGE_FN,$@)
 
@@ -369 +374 @@
                         '$(subst /,\,$<)'
         $(QUIET)$(REDIRECT) -- $(VBOX_PE_SET_VERSION) $@
+        $(QUIET)$(REDIRECT) -- $(VBOX_NSIS_TOOL) repair $@
 
  $(PATH_TARGET)/uninst.exe: \