Changeset 107412 in vbox

Timestamp:

Jan 6, 2025 12:00:49 PM (5 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

166463

Message:

FE/Qt: bugref:3409: Runtime UI: Fixing lots of parfait warnings in UI session code, related to implicit type conversion.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/runtime/UISession.cpp (modified) (21 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UISession.cpp

@@ -586 +586 @@
     if (comMouse.isNull())
         return false;
-    comMouse.PutMouseEvent(iDx, iDy, iDz, iDw, iButtonState);
+    comMouse.PutMouseEvent((LONG)iDx, (LONG)iDy,
+                           (LONG)iDz, (LONG)iDw,
+                           (LONG)iButtonState);
     return comMouse.isOk();
 }
@@ -595 +597 @@
     if (comMouse.isNull())
         return false;
-    comMouse.PutMouseEventAbsolute(iX, iY, iDz, iDw, iButtonState);
+    comMouse.PutMouseEventAbsolute((LONG)iX, (LONG)iY,
+                                   (LONG)iDz, (LONG)iDw,
+                                   (LONG)iButtonState);
     return comMouse.isOk();
 }
@@ -604 +608 @@
     if (comMouse.isNull())
         return false;
-    comMouse.PutEventMultiTouch(iCount, contacts, fIsTouchScreen, uScanTime);
+    comMouse.PutEventMultiTouch((LONG)iCount, contacts, fIsTouchScreen, (ULONG)uScanTime);
     return comMouse.isOk();
 }
@@ -783 +787 @@
                 default: break;
             }
-            const long iPort = comAttachment.GetPort();
+            const int iPort = comAttachment.GetPort();
             fSuccess = comAttachment.isOk();
             if (!fSuccess)
@@ -790 +794 @@
                 break;
             }
-            const long iDevice = comAttachment.GetDevice();
+            const int iDevice = comAttachment.GetDevice();
             fSuccess = comAttachment.isOk();
             if (!fSuccess)
@@ -1252 +1256 @@
 {
     CMachine comMachine = machine();
-    CNetworkAdapter comAdapter = comMachine.GetNetworkAdapter(uSlot);
+    CNetworkAdapter comAdapter = comMachine.GetNetworkAdapter((ULONG)uSlot);
     bool fSuccess = comMachine.isOk();
     if (!fSuccess)
@@ -1317 +1321 @@
 {
     CMachine comMachine = machine();
-    CNetworkAdapter comAdapter = comMachine.GetNetworkAdapter(uSlot);
+    CNetworkAdapter comAdapter = comMachine.GetNetworkAdapter((ULONG)uSlot);
     bool fSuccess = comMachine.isOk();
     if (!fSuccess)
@@ -1336 +1340 @@
 {
     CMachine comMachine = machine();
-    CNetworkAdapter comAdapter = comMachine.GetNetworkAdapter(uSlot);
+    CNetworkAdapter comAdapter = comMachine.GetNetworkAdapter((ULONG)uSlot);
     bool fSuccess = comMachine.isOk();
     if (!fSuccess)
@@ -1641 +1645 @@
     LONG iGuestXOrigin = 0, iGuestYOrigin = 0;
     KGuestMonitorStatus enmGuestMonitorStatus = KGuestMonitorStatus_Disabled;
-    comDisplay.GetScreenResolution(uScreenId, uGuestWidth, uGuestHeight, uGuestBitsPerPixel,
+    comDisplay.GetScreenResolution((ULONG)uScreenId, uGuestWidth, uGuestHeight, uGuestBitsPerPixel,
                                    iGuestXOrigin, iGuestYOrigin, enmGuestMonitorStatus);
     const bool fSuccess = comDisplay.isOk();
@@ -1665 +1669 @@
     ULONG uGuestXOrigin = 0, uGuestYOrigin = 0, uGuestWidth = 0, uGuestHeight = 0;
     BOOL fGuestEnabled = FALSE;
-    comMachine.QuerySavedGuestScreenInfo(uScreenId, uGuestXOrigin, uGuestYOrigin, uGuestWidth, uGuestHeight, fGuestEnabled);
+    comMachine.QuerySavedGuestScreenInfo((ULONG)uScreenId, uGuestXOrigin, uGuestYOrigin,
+                                         uGuestWidth, uGuestHeight, fGuestEnabled);
     const bool fSuccess = comMachine.isOk();
     if (!fSuccess)
@@ -1684 +1689 @@
 {
     CDisplay comDisplay = display();
-    comDisplay.SetVideoModeHint(uScreenId, fEnabled, fChangeOrigin, xOrigin, yOrigin,
-                                uWidth, uHeight, uBitsPerPixel, fNotify);
+    comDisplay.SetVideoModeHint((ULONG)uScreenId,
+                                fEnabled,
+                                fChangeOrigin,
+                                (LONG)xOrigin, (LONG)yOrigin,
+                                (ULONG)uWidth, (ULONG)uHeight, (ULONG)uBitsPerPixel,
+                                fNotify);
     const bool fSuccess = comDisplay.isOk();
     if (!fSuccess)
@@ -1700 +1709 @@
     LONG iGuestXOrigin = 0, iGuestYOrigin = 0;
     ULONG uGuestWidth = 0, uGuestHeight = 0, uGuestBitsPerPixel = 0;
-    comDisplay.GetVideoModeHint(uScreenId, fGuestEnabled, fGuestChangeOrigin,
+    comDisplay.GetVideoModeHint((ULONG)uScreenId, fGuestEnabled, fGuestChangeOrigin,
                                 iGuestXOrigin, iGuestYOrigin, uGuestWidth, uGuestHeight,
                                 uGuestBitsPerPixel);
@@ -1727 +1736 @@
     {
         /* Take screen-data to array first: */
-        const QVector<BYTE> screenData = comDisplay.TakeScreenShotToArray(uScreenId, uWidth, uHeight, enmFormat);
+        const QVector<BYTE> screenData = comDisplay.TakeScreenShotToArray((ULONG)uScreenId,
+                                                                          (ULONG)uWidth,
+                                                                          (ULONG)uHeight,
+                                                                          enmFormat);
         fSuccess = comDisplay.isOk();
         if (!fSuccess)
@@ -1742 +1754 @@
     {
         /* Take the screen-shot directly: */
-        comDisplay.TakeScreenShot(uScreenId, pBits, uWidth, uHeight, enmFormat);
+        comDisplay.TakeScreenShot((ULONG)uScreenId,
+                                  pBits,
+                                  (ULONG)uWidth,
+                                  (ULONG)uHeight,
+                                  enmFormat);
         fSuccess = comDisplay.isOk();
         if (!fSuccess && comDisplay.rc() != VBOX_E_NOT_SUPPORTED) /* VBOX_E_NOT_SUPPORTED: screens size 0x0 can't be snapshotted */
@@ -1754 +1770 @@
     CMachine comMachine = machine();
     ULONG uGuestWidth = 0, uGuestHeight = 0;
-    QVector<KBitmapFormat> guestFormats = comMachine.QuerySavedScreenshotInfo(uScreenId, uGuestWidth, uGuestHeight);
+    QVector<KBitmapFormat> guestFormats = comMachine.QuerySavedScreenshotInfo((ULONG)uScreenId,
+                                                                              uGuestWidth, uGuestHeight);
     const bool fSuccess = comMachine.isOk();
     if (!fSuccess)
@@ -1772 +1789 @@
     CMachine comMachine = machine();
     ULONG uGuestWidth = 0, uGuestHeight = 0;
-    const QVector<BYTE> guestScreenshot = comMachine.ReadSavedScreenshotToArray(uScreenId, enmFormat,
+    const QVector<BYTE> guestScreenshot = comMachine.ReadSavedScreenshotToArray((ULONG)uScreenId, enmFormat,
                                                                                 uGuestWidth, uGuestHeight);
     const bool fSuccess = comMachine.isOk();
@@ -1821 +1838 @@
     if (comDisplay.isNull())
         return false;
-    comDisplay.ViewportChanged(uScreenId, xOrigin, yOrigin, uWidth, uHeight);
+    comDisplay.ViewportChanged((ULONG)uScreenId, (ULONG)xOrigin, (ULONG)yOrigin, (ULONG)uWidth, (ULONG)uHeight);
     const bool fSuccess = comDisplay.isOk();
     if (!fSuccess)
@@ -1841 +1858 @@
 {
     CDisplay comDisplay = display();
-    comDisplay.InvalidateAndUpdateScreen(uScreenId);
+    comDisplay.InvalidateAndUpdateScreen((ULONG)uScreenId);
     const bool fSuccess = comDisplay.isOk();
     if (!fSuccess)
@@ -2326 +2343 @@
     {
         const QRect rct = activeMachineWindow()->frameGeometry();
-        m_pDbgGuiVT->pfnAdjustRelativePos(m_pDbgGui, rct.x(), rct.y(), rct.width(), rct.height());
+        m_pDbgGuiVT->pfnAdjustRelativePos(m_pDbgGui, rct.x(), rct.y(), (uint)rct.width(), (uint)rct.height());
     }
 }
@@ -2637 +2654 @@
     ulong cGuestScreenCount = 0;
     acquireMonitorCount(cGuestScreenCount);
-    m_frameBufferVector.resize(cGuestScreenCount);
+    m_frameBufferVector.resize((int)cGuestScreenCount);
 
     /* Create new frame-buffers: */
@@ -2765 +2782 @@
         CPlatform comPlatform             = machine().GetPlatform();
         CPlatformProperties comProperties = gpGlobalSession->virtualBox().GetPlatformProperties(comPlatform.GetArchitecture());
-        const ulong cCount = comProperties.GetMaxNetworkAdapters(comPlatform.GetChipsetType());
-        for (ulong uAdapterIndex = 0; uAdapterIndex < cCount; ++uAdapterIndex)
+        const ULONG cCount = comProperties.GetMaxNetworkAdapters(comPlatform.GetChipsetType());
+        for (ULONG uAdapterIndex = 0; uAdapterIndex < cCount; ++uAdapterIndex)
         {
             CNetworkAdapter comNetworkAdapter = machine().GetNetworkAdapter(uAdapterIndex);