Changeset 107428 in vbox for trunk/src

Timestamp:

Jan 6, 2025 5:01:30 PM (13 days ago)

Author:

vboxsync

Message:

Devices/Security: Fix some harmless repeated expansion of macro argument with side-effects parfait warnings (the called functions don't have side effects), bugref:3409

Location:

trunk/src/VBox/Devices/Security

Files:

• DrvTpmEmu.cpp (modified) (1 diff)
• DrvTpmEmuTpms.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Security/DrvTpmEmu.cpp

@@ -961 +961 @@
 
     /* Limit to the maximum buffer size of the device above. */
-    pThis->cbBuffer = RT_MIN(pThis->cbBuffer, pThis->pTpmPort->pfnGetMaxBufferSize(pThis->pTpmPort));
+    uint32_t const cbTpmBufferMax = pThis->pTpmPort->pfnGetMaxBufferSize(pThis->pTpmPort);
+    pThis->cbBuffer = RT_MIN(pThis->cbBuffer, cbTpmBufferMax);
 
     /* Set the buffer size. */

trunk/src/VBox/Devices/Security/DrvTpmEmuTpms.cpp

@@ -544 +544 @@
 
     /* Limit to the buffer size of the device above. */
-    pThis->cbBuffer = RT_MIN(pThis->cbBuffer, pThis->pTpmPort->pfnGetMaxBufferSize(pThis->pTpmPort));
+    uint32_t const cbTpmBufferMax = pThis->pTpmPort->pfnGetMaxBufferSize(pThis->pTpmPort);
+    pThis->cbBuffer = RT_MIN(pThis->cbBuffer, cbTpmBufferMax);
 
     uint32_t cbBufferMin = 0;