Changeset 107438 in vbox

Timestamp:

Jan 6, 2025 6:25:57 PM (12 days ago)

Author:

vboxsync

Message:

Main/ApplianceImplImport.cpp: Fixed a warning found by Parfait. ​However, this is needs a more major review + cleanup, see @todos. jiraref:VBP-1424

File:

• trunk/src/VBox/Main/src-server/ApplianceImplImport.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-server/ApplianceImplImport.cpp

@@ -592 +592 @@
                 const ovf::HardDiskController &hdc = hdcIt->second;
 
+                /** @todo r=andy The following count checks look messy/wrong compared to what we define
+                 *               elsewhere (e.g. PlatformProperties).  Needs to be checked (and fixed). */
+
                 switch (hdc.system)
                 {
                     case ovf::HardDiskController::IDE:
                         /* Check for the constraints */
-                        if (cIDEused < 4)
+                        if (cIDEused < 4) /** @todo r=andy Is this really true? */
                         {
                             /// @todo figure out the IDE types
@@ -612 +615 @@
                         else
                             /* Warn only once */
-                            if (cIDEused == 2)
+                            if (cIDEused == 4) /** @todo r=andy See todo above. */
                                 i_addWarning(tr("Virtual appliance \"%s\" was configured with more than two "
                                                 "IDE controllers however VirtualBox supports a maximum of two "