Changeset 107447 in vbox for trunk/src/VBox/Main

Timestamp:

Jan 7, 2025 8:42:50 AM (4 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

166500

Message:

Main/src-server/ApplianceImplImport.cpp: Don't do the string -> uint64_t conversion multiple times (macro expands it multiple times), and use RT_CLAMP instead of nesting RT_MIN/RT_MAX to make the code easier to digest, bugref:3409

File:

• trunk/src/VBox/Main/src-server/ApplianceImplImport.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-server/ApplianceImplImport.cpp

@@ -1836 +1836 @@
                     {
                         vsdData = aVBoxValues[0];
-                        memoryInBytes = RT_MIN((uint64_t)(RT_MAX(vsdData.toUInt64(), (uint64_t)MM_RAM_MIN)), MM_RAM_MAX);
+
+                        uint64_t cbRam = vsdData.toUInt64();
+                        memoryInBytes = RT_CLAMP(cbRam, (uint64_t)MM_RAM_MIN, (uint64_t)MM_RAM_MAX);
                     }
                     //and set in ovf::VirtualSystem in bytes