Changeset 107476 in vbox for trunk/src

Timestamp:

Jan 8, 2025 4:59:50 AM (11 days ago)

Author:

vboxsync

Message:

FE/Qt: bugref:3409: VM Settings / Storage page: Fix for similar parfait warnings related to redundant condition.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsStorage.cpp (modified) (4 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsStorage.cpp

@@ -639 +639 @@
         {
             /* Save controller type: */
-            if (fSuccess)
+            // if (fSuccess)
             {
                 comController.SetControllerType(newControllerData.m_guiValue.m_enmType);
@@ -658 +658 @@
             {
                 ULONG uNewPortCount = newControllerData.m_guiValue.m_uPortCount;
-                if (fSuccess)
+                // if (fSuccess)
                 {
                     uNewPortCount = qMax(uNewPortCount, comController.GetMinPortCount());
@@ -718 +718 @@
         {
             /* Save controller type: */
-            if (fSuccess && newControllerData.m_guiValue.m_enmType != oldControllerData.m_guiValue.m_enmType)
+            if (/*fSuccess &&*/ newControllerData.m_guiValue.m_enmType != oldControllerData.m_guiValue.m_enmType)
             {
                 comController.SetControllerType(newControllerData.m_guiValue.m_enmType);
@@ -738 +738 @@
             {
                 ULONG uNewPortCount = newControllerData.m_guiValue.m_uPortCount;
-                if (fSuccess)
+                // if (fSuccess)
                 {
                     uNewPortCount = qMax(uNewPortCount, comController.GetMinPortCount());