Changeset 107488 in vbox for trunk/src/VBox/Main/src-server

Timestamp:

Jan 8, 2025 9:58:47 AM (2 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

166547

Message:

Main/src-server/MediumImpl.cpp: Fix unused assignment and missing field initialiser parfait warnings, bugref:3409

File:

• trunk/src/VBox/Main/src-server/MediumImpl.cpp (modified) (4 diffs)

trunk/src/VBox/Main/src-server/MediumImpl.cpp

@@ -190 +190 @@
           uOpenFlagsDef(VD_OPEN_FLAGS_IGNORE_FLUSH),
           numCreateDiffTasks(0),
+          hTcpNetInst(NULL),
           vdDiskIfaces(NULL),
           vdImageIfaces(NULL),
@@ -3462 +3463 @@
         std::vector<com::Guid> aMachineIds;
         hrc = getMachineIds(aMachineIds);
+        if (FAILED(hrc))
+            throw setError(hrc, tr("Failed to get machine list '%s' is attached to"), i_getLocationFull().c_str());
+
         std::vector<com::Guid>::const_iterator currMachineID = aMachineIds.begin();
         std::vector<com::Guid>::const_iterator lastMachineID = aMachineIds.end();
@@ -10056 +10060 @@
     const ComObjPtr<Medium> &pTarget = task.mMedium;
 
-    uint64_t size = 0; NOREF(size);
-    uint64_t logicalSize = 0; NOREF(logicalSize);
-    MediumVariant_T variant = MediumVariant_Standard; NOREF(variant);
-
     /*
      * it's exactly moving, not cloning
@@ -10156 +10156 @@
                                        tr("Could not move medium '%s'%s"),
                                        targetLocation.c_str(), i_vdError(vrc).c_str());
-                size = VDGetFileSize(hdd, VD_LAST_IMAGE);
-                logicalSize = VDGetSize(hdd, VD_LAST_IMAGE);
-                unsigned uImageFlags;
-                vrc = VDGetImageFlags(hdd, 0, &uImageFlags);
-                if (RT_SUCCESS(vrc))
-                    variant = (MediumVariant_T)uImageFlags;
 
                 /*