Changeset 107492 in vbox for trunk/src/VBox/Main

Timestamp:

Jan 8, 2025 10:14:39 AM (6 weeks ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

166551

Message:

Main/src-client/ConsoleImplArmV8.cpp: Missing error checks, bugref:3409

File:

• trunk/src/VBox/Main/src-client/ConsoleImplConfigArmV8.cpp (modified) (6 diffs)

trunk/src/VBox/Main/src-client/ConsoleImplConfigArmV8.cpp

@@ -283 +283 @@
         vrc = RTFdtNodePropertyAddEmpty(   hFdt, "always-on");                              VRC();
         vrc = RTFdtNodePropertyAddString(  hFdt, "compatible",       "arm,armv8-timer");    VRC();
-        vrc = RTFdtNodeFinalize(hFdt);
+        vrc = RTFdtNodeFinalize(hFdt);                                                      VRC();
 
         vrc = RTFdtNodeAdd(hFdt, "apb-clk");                                                VRC();
@@ -291 +291 @@
         vrc = RTFdtNodePropertyAddU32(     hFdt, "#clock-cells",       0);                  VRC();
         vrc = RTFdtNodePropertyAddString(  hFdt, "compatible",         "fixed-clock");      VRC();
-        vrc = RTFdtNodeFinalize(hFdt);
+        vrc = RTFdtNodeFinalize(hFdt);                                                      VRC();
 
         if (pSysTblsBldAcpi)
@@ -773 +773 @@
         vrc = RTFdtNodePropertyAddU32(     hFdt, "linux,code", 0xcd);                       VRC();
         vrc = RTFdtNodePropertyAddString(  hFdt, "label",      "GPIO Key Suspend");         VRC();
-        vrc = RTFdtNodeFinalize(hFdt);
+        vrc = RTFdtNodeFinalize(hFdt);                                                      VRC();
 
         vrc = RTFdtNodeFinalize(hFdt);                                                      VRC();
@@ -855 +855 @@
         }
 
-        vrc = RTFdtNodePropertyAddCellsU32AsArray(hFdt, "interrupt-map", RT_ELEMENTS(aIrqCells), &aIrqCells[0]);
+        vrc = RTFdtNodePropertyAddCellsU32AsArray(hFdt, "interrupt-map", RT_ELEMENTS(aIrqCells), &aIrqCells[0]); VRC();
         vrc = RTFdtNodePropertyAddU32(     hFdt, "#interrupt-cells", 1);                        VRC();
         vrc = RTFdtNodePropertyAddCellsU32(hFdt, "ranges", 21,
@@ -961 +961 @@
         vrc = mptrExtPackManager->i_callAllVmConfigureVmmHooks(this, pVM, pVMM);
         pAlock->acquire();
+        AssertRCReturnStmt(vrc, RTFdtDestroy(hFdt), vrc);
     }
 #endif
@@ -1068 +1069 @@
     vrc = RTVfsIoStrmWrite(hVfsIosDesc, &ArmV8Platform, sizeof(ArmV8Platform), true /*fBlocking*/, NULL /*pcbWritten*/);
     RTVfsIoStrmRelease(hVfsIosDesc);
+    AssertRCReturnStmt(vrc, RTVfsFileRelease(hVfsFileDesc), vrc);
+
     vrc = mptrResourceStore->i_addItem("resources", "VBoxArmV8Desc", hVfsFileDesc);
     RTVfsFileRelease(hVfsFileDesc);