Changeset 107552 in vbox for trunk

Timestamp:

Jan 9, 2025 8:37:51 AM (10 days ago)

Author:

vboxsync

Message:

Main/src-server/UefiVariableStoreImpl.cpp: Missing error check and add exception for debug only use of a variable, bugref:3409

File:

• trunk/src/VBox/Main/src-server/UefiVariableStoreImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-server/UefiVariableStoreImpl.cpp

@@ -374 +374 @@
 
         vrc = RTVfsDirReadEx(hVfsDir, &DirEntry, NULL, RTFSOBJATTRADD_NOTHING);
-        for (;;)
+        if (RT_SUCCESS(vrc))
         {
-            RTUUID OwnerUuid;
-            vrc = i_uefiVarStoreQueryVarOwnerUuid(DirEntry.szName, &OwnerUuid);
-            if (RT_FAILURE(vrc))
-                break;
-
-            aNames.push_back(Utf8Str(DirEntry.szName));
-            aOwnerUuids.push_back(com::Guid(OwnerUuid));
-
-            vrc = RTVfsDirReadEx(hVfsDir, &DirEntry, NULL, RTFSOBJATTRADD_NOTHING);
-            if (RT_FAILURE(vrc))
-                break;
+            for (;;)
+            {
+                RTUUID OwnerUuid;
+                vrc = i_uefiVarStoreQueryVarOwnerUuid(DirEntry.szName, &OwnerUuid);
+                if (RT_FAILURE(vrc))
+                    break;
+
+                aNames.push_back(Utf8Str(DirEntry.szName));
+                aOwnerUuids.push_back(com::Guid(OwnerUuid));
+
+                vrc = RTVfsDirReadEx(hVfsDir, &DirEntry, NULL, RTFSOBJATTRADD_NOTHING);
+                if (RT_FAILURE(vrc))
+                    break;
+            }
+
+            if (vrc == VERR_NO_MORE_FILES)
+                vrc = VINF_SUCCESS;
         }
-
-        if (vrc == VERR_NO_MORE_FILES)
-            vrc = VINF_SUCCESS;
 
         RTVfsDirRelease(hVfsDir);