Changeset 107584 in vbox for trunk/src/VBox/Frontends

Timestamp:

Jan 9, 2025 10:21:08 AM (4 weeks ago)

Author:

vboxsync

Message:

FE/Qt: bugref:3409: Action-pool: Fixing similar parfait warnings for coding pattern, related to unused variables; S.a. commits for Runtime and Manager action-pools: r166529, r166539; Besides that, adding some sanity checks for addAction stuff as passed pointers can indeed be null.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/globals/UIActionPool.cpp (modified) (4 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/globals/UIActionPool.cpp

@@ -3548 +3548 @@
 bool UIActionPool::addAction(UIMenu *pMenu, UIAction *pAction, bool fReallyAdd /* = true */)
 {
+    /* Sanity check: */
+    AssertPtrReturn(pMenu, false);
+    AssertPtrReturn(pAction, false);
+
     /* Check if action is allowed: */
     const bool fIsActionAllowed = pAction->isAllowed();
@@ -3675 +3679 @@
     /* 'Close' action: */
     fSeparator = addAction(pMenu, action(UIActionIndex_M_Application_S_Close)) || fSeparator;
+
+    /* Remove if fSeparator is used: */
+    Q_UNUSED(fSeparator);
 
     /* Mark menu as valid: */
@@ -3742 +3749 @@
 #endif
 
+    /* Remove if fSeparator is used: */
+    Q_UNUSED(fSeparator);
+
     /* Mark menu as valid: */
     m_invalidations.remove(UIActionIndex_Menu_Help);
@@ -3801 +3811 @@
     fSeparator = addAction(pMenu, action(UIActionIndex_M_Log_S_Refresh)) || fSeparator;
     fSeparator = addAction(pMenu, action(UIActionIndex_M_Log_S_Reload)) || fSeparator;
+
+    /* Remove if fSeparator is used: */
+    Q_UNUSED(fSeparator);
 }