Changeset 107586 in vbox for trunk

Timestamp:

Jan 9, 2025 10:31:28 AM (10 days ago)

Author:

vboxsync

Message:

FE/Qt: bugref:3409: Search-line editor: Fixing parfait warnings for coding pattern, related to self-excluding and thus unnecessary condition check.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/widgets/UISearchLineEdit.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/widgets/UISearchLineEdit.cpp

@@ -103 +103 @@
 void UISearchLineEdit::colorBackground(bool fWarning)
 {
-    QPalette mPalette = QApplication::palette();
-    /** Make sure we reset color. */
+    /** Make sure we reset color: */
+    QPalette pal = QApplication::palette();
     if (!fWarning || !m_fMark)
-    {
-        mPalette.setColor(QPalette::Base, m_unmarkColor);
-        setPalette(mPalette);
-        return;
-    }
-
-    if (m_fMark && fWarning)
-    {
-        mPalette.setColor(QPalette::Base, m_markColor);
-        setPalette(mPalette);
-        return;
-    }
+        pal.setColor(QPalette::Base, m_unmarkColor);
+    else
+        pal.setColor(QPalette::Base, m_markColor);
+    setPalette(pal);
 }