Changeset 107592 in vbox for trunk/src/VBox/Devices

Timestamp:

Jan 9, 2025 11:31:47 AM (2 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

166665

Message:

src/VBox/Devices/Audio/DevIchAc97.cpp: Fixed warnings found by Parfait (assignment unused) [build fix]. jiraref:VBP-1424

File:

• trunk/src/VBox/Devices/Audio/DevIchAc97.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Audio/DevIchAc97.cpp

@@ -3183 +3183 @@
      */
     bool const  fCtlMuted     = (uVal >> AC97_BARS_VOL_MUTE_SHIFT) & 1;
+# ifdef VBOX_WITH_AC97_GAIN_SUPPORT
     uint8_t     uCtlGainLeft  = (uVal >> 8) & AC97_BARS_GAIN_MASK;
     uint8_t     uCtlGainRight = uVal & AC97_BARS_GAIN_MASK;
-
     Assert(uCtlGainLeft  <= 255 / AC97_DB_FACTOR);
     Assert(uCtlGainRight <= 255 / AC97_DB_FACTOR);
+    LogFunc(("uCtlGainLeft=%RU8, uCtlGainRight=%RU8 ", uCtlGainLeft, uCtlGainRight));
+# endif
 
     LogFunc(("index=0x%x, uVal=%RU32, enmMixerCtl=%RU32\n", index, uVal, enmMixerCtl));
-    LogFunc(("uCtlGainLeft=%RU8, uCtlGainRight=%RU8 ", uCtlGainLeft, uCtlGainRight));
 
     uint8_t lVol;
@@ -3198 +3199 @@
      * for the recording input, the best we can do is set the maximum volume.
      */
-# ifndef VBOX_WITH_AC97_GAIN_SUPPORT
+# ifdef VBOX_WITH_AC97_GAIN_SUPPORT
+    lVol = PDMAUDIO_VOLUME_MAX + uCtlGainLeft  * AC97_DB_FACTOR;
+    rVol = PDMAUDIO_VOLUME_MAX + uCtlGainRight * AC97_DB_FACTOR;
+# else
     /* NB: Currently there is no gain support, only attenuation. Since AC'97 does not
      * support attenuation for the recording inputs, the best we can do is set the
@@ -3204 +3208 @@
      */
     lVol = rVol = PDMAUDIO_VOLUME_MAX;
-# else
-    lVol = PDMAUDIO_VOLUME_MAX + uCtlGainLeft  * AC97_DB_FACTOR;
-    rVol = PDMAUDIO_VOLUME_MAX + uCtlGainRight * AC97_DB_FACTOR;
 # endif