Changeset 107596 in vbox for trunk/src/VBox/Storage

Timestamp:

Jan 9, 2025 12:27:40 PM (2 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

166671

Message:

Storage/VD.cpp: Some parfait warning fixes about unused assignments und unread variables, bugref:3409

File:

• trunk/src/VBox/Storage/VD.cpp (modified) (9 diffs)

trunk/src/VBox/Storage/VD.cpp

@@ -895 +895 @@
                 if (idxEnd != -1)
                 {
-                    cbThis = (idxEnd - idxStart) * 512;
+                    cbThis = (size_t)(idxEnd - idxStart) * 512;
                     fAllocated = false;
                 }
@@ -904 +904 @@
                 idxEnd = ASMBitNextSet(pBlock->pbmAllocated, cSectors, idxStart);
                 if (idxEnd != -1)
-                    cbThis = (idxEnd - idxStart) * 512;
+                    cbThis = (size_t)(idxEnd - idxStart) * 512;
 
 
@@ -2942 +2942 @@
                 if (idxEnd != -1)
                 {
-                    cbThis = (idxEnd - idxStart) * 512;
+                    cbThis = (size_t)(idxEnd - idxStart) * 512;
                     fAllocated = false;
                 }
@@ -2951 +2951 @@
                 idxEnd = ASMBitNextSet(pBlock->pbmAllocated, cSectors, idxStart);
                 if (idxEnd != -1)
-                    cbThis = (idxEnd - idxStart) * 512;
+                    cbThis = (size_t)(idxEnd - idxStart) * 512;
 
                 rc = pDisk->pLast->Backend->pfnDiscard(pDisk->pLast->pBackendData, pIoCtx,
@@ -4071 +4071 @@
         rc = pVDIo->pInterfaceIo->pfnWriteSync(pVDIo->pInterfaceIo->Core.pvUser,
                                               pIoStorage->pStorage, uOffset,
-                                              Seg.pvSeg, cbWrite, NULL);
+                                              Seg.pvSeg, cbTaskWrite, NULL);
         if (RT_SUCCESS(rc))
         {
-            Assert(pIoCtx->Req.Io.cbTransferLeft >= cbWrite);
-            ASMAtomicSubU32(&pIoCtx->Req.Io.cbTransferLeft, (uint32_t)cbWrite);
+            Assert(pIoCtx->Req.Io.cbTransferLeft >= cbTaskWrite);
+            ASMAtomicSubU32(&pIoCtx->Req.Io.cbTransferLeft, (uint32_t)cbTaskWrite);
         }
     }
@@ -6946 +6946 @@
                 rc2 = vdThreadStartWrite(pDisk);
                 AssertRC(rc2);
-                fLockWrite = true;
+                /*fLockWrite = true; No effect */
 
                 pDisk->pImageRelay = pImageTo;
@@ -6952 +6952 @@
                 rc2 = vdThreadFinishWrite(pDisk);
                 AssertRC(rc2);
-                fLockWrite = false;
+                /*fLockWrite = false; No effect */
             }
 
@@ -7047 +7047 @@
                 rc2 = vdThreadStartWrite(pDisk);
                 AssertRC(rc2);
-                fLockWrite = true;
+                /*fLockWrite = true; No effect */
 
                 pDisk->pImageRelay = NULL;
@@ -7053 +7053 @@
                 rc2 = vdThreadFinishWrite(pDisk);
                 AssertRC(rc2);
-                fLockWrite = false;
+                /*fLockWrite = false; No effect */
             }
         }