Changeset 107637 in vbox for trunk/src/VBox/Frontends

Timestamp:

Jan 10, 2025 12:32:20 PM (4 weeks ago)

Author:

vboxsync

Message:

FE/Qt: bugref:3409: VISO browser: Fixing false-positive parfait warnings related to null pointer dereference.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/medium/viso/UIVisoContentBrowser.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/medium/viso/UIVisoContentBrowser.cpp

@@ -1068 +1068 @@
 void UIVisoContentBrowser::updateStartItemName()
 {
-    if (!rootItem() || !rootItem()->child(0))
+    UIFileSystemItem *pRoot = rootItem();
+    if (!pRoot)
+        return;
+    UIFileSystemItem *pChild = pRoot->child(0);
+    if (!pChild)
         return;
     const QString strName(QDir::toNativeSeparators("/"));
 
-    rootItem()->child(0)->setData(strName, UIFileSystemModelData_Name);
+    pChild->setData(strName, UIFileSystemModelData_Name);
     /* If the table root index is the start item then we have to update the location selector text here: */
-    // if (m_pProxyModel->mapToSource(m_pTableView->rootIndex()).internalPointer() == rootItem()->child(0))
+    // if (m_pProxyModel->mapToSource(m_pTableView->rootIndex()).internalPointer() == pChild)
     //     updateLocationSelectorText(strName);
     m_pProxyModel->invalidate();
@@ -1138 +1142 @@
 void UIVisoContentBrowser::sltResetAction()
 {
-    if (!rootItem() || !rootItem()->child(0))
+    UIFileSystemItem *pRoot = rootItem();
+    if (!pRoot)
+        return;
+    UIFileSystemItem *pChild = pRoot->child(0);
+    if (!pChild)
         return;
     goToStart();
-    rootItem()->child(0)->removeChildren();
+    pChild->removeChildren();
     m_entryMap.clear();
     if (m_pProxyModel)