Changeset 107665 in vbox for trunk/src/VBox/HostServices

Timestamp:

Jan 10, 2025 3:20:33 PM (4 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

166757

Message:

GuestProperties/testcase/tstGuestPropSvc.cpp: Fix parfait warnings about unused assignments, bugref:3409

File:

• trunk/src/VBox/HostServices/GuestProperties/testcase/tstGuestPropSvc.cpp (modified) (3 diffs)

trunk/src/VBox/HostServices/GuestProperties/testcase/tstGuestPropSvc.cpp

@@ -196 +196 @@
             RTTestIFailed("Flags 0x%x were incorrectly written out as '%.*s'\n",
                           u32BadFlags, GUEST_PROP_MAX_FLAGS_LEN, pszFlagBuffer);
-            rc = VERR_PARSE_ERROR;
+            /*rc = VERR_PARSE_ERROR;*/
         }
     }
@@ -983 +983 @@
     s_aDelPropertiesROGuest[] =
     {
-        { "Red", true, true, "", true },
-        { "Amber", false, true, "", true },
-        { "Red2", true, false, "", true },
-        { "Amber2", false, false, "", true },
-        { "Red3", true, true, "READONLY", false },
-        { "Amber3", false, true, "READONLY", false },
-        { "Red4", true, true, "RDONLYHOST", false },
-        { "Amber4", false, true, "RDONLYHOST", true },
+        { "Red",    true,  true,  "",           true  },
+        { "Amber",  false, true,  "",           true  },
+        { "Red2",   true,  false, "",           true  },
+        { "Amber2", false, false, "",           true  },
+        { "Red3",   true,  true,  "READONLY",   false },
+        { "Amber3", false, true,  "READONLY",   false },
+        { "Red4",   true,  true,  "RDONLYHOST", false },
+        { "Amber4", false, true,  "RDONLYHOST", true  },
     };
 
@@ -1000 +1000 @@
         {
             if (s_aDelPropertiesROGuest[i].shouldCreate)
+            {
                 rc = doSetProperty(pTable, s_aDelPropertiesROGuest[i].pcszName,
                                    "none", s_aDelPropertiesROGuest[i].pcszFlags,
                                    true, true);
+                if (RT_FAILURE(rc))
+                    RTTestIFailed("Creating property '%s' on the host failed with rc=%Rrc.",
+                                  s_aDelPropertiesROGuest[i].pcszName, rc);
+            }
             rc = doDelProp(pTable, s_aDelPropertiesROGuest[i].pcszName,
                            s_aDelPropertiesROGuest[i].isHost);