Changeset 107683 in vbox

Timestamp:

Jan 10, 2025 4:23:24 PM (4 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

166776

Message:

src/VBox/Main/src-client/WebMWriter.cpp: Fixed warnings found by Parfait (unused assignment + unread variable). jiraref:VBP-1424

File:

• trunk/src/VBox/Main/src-client/WebMWriter.cpp (modified) (6 diffs)

trunk/src/VBox/Main/src-client/WebMWriter.cpp

@@ -71 +71 @@
                        RecordingAudioCodec_T a_enmAudioCodec, RecordingVideoCodec_T a_enmVideoCodec)
 {
+    int vrc;
+
     try
     {
         LogFunc(("Creating '%s'\n", a_pszFilename));
 
-        int vrc = createEx(a_pszFilename, a_phFile);
+        vrc = createEx(a_pszFilename, a_phFile);
         if (RT_SUCCESS(vrc))
         {
@@ -83 +85 @@
         }
     }
-    catch(int vrc)
-    {
-        return vrc;
-    }
-    return VINF_SUCCESS;
+    catch(int vrcEx)
+    {
+        vrc = vrcEx;
+    }
+
+    return vrc;
 }
 
@@ -102 +105 @@
                      RecordingAudioCodec_T a_enmAudioCodec, RecordingVideoCodec_T a_enmVideoCodec)
 {
+    int vrc;
+
     try
     {
         LogFunc(("Creating '%s'\n", a_pszFilename));
 
-        int vrc = create(a_pszFilename, a_fOpen);
+        vrc = create(a_pszFilename, a_fOpen);
         if (RT_SUCCESS(vrc))
         {
@@ -114 +119 @@
         }
     }
-    catch(int vrc)
-    {
-        return vrc;
-    }
-    return VINF_SUCCESS;
+    catch(int vrcEx)
+    {
+        vrc = vrcEx;
+    }
+
+    return vrc;
 }
 
@@ -615 +621 @@
             && !mapBlocks.fClusterStarted)
         {
-            /* Last written timecode of the current cluster. */
-            uint64_t tcAbsClusterLastWrittenMs;
-
             if (Cluster.fOpen) /* Close current cluster first. */
             {
@@ -627 +630 @@
                 Assert(Cluster.cBlocks);
 
-                /* Save the last written timecode of the current cluster before closing it. */
-                tcAbsClusterLastWrittenMs = Cluster.tcAbsLastWrittenMs;
-
                 subEnd(MkvElem_Cluster);
                 Cluster.fOpen = false;
             }
-            else /* First cluster ever? Use the segment's starting timecode. */
-                tcAbsClusterLastWrittenMs = m_CurSeg.m_tcAbsStartMs;
 
             Cluster.fOpen              = true;