Changeset 107686 in vbox

Timestamp:

Jan 10, 2025 4:34:50 PM (6 weeks ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

166779

Message:

FE/Qt: bugref:3409: Runtime UI / UI session: Fixing parfait warning related to redundant condition check; Related to storage device stuff.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/runtime/UISession.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UISession.cpp

@@ -765 +765 @@
             }
 
-            /* Fill structure fields: */
+            /* Fill and append structure fields: */
             StorageDeviceInfo guiStorageDevice;
             guiStorageDevice.m_strControllerName = strControllerName; // already confirmed
@@ -801 +801 @@
                 break;
             }
-            if (fSuccess)
-            {
-                const StorageSlot guiStorageSlot(enmStorageBus, iPort, iDevice);
-                guiStorageDevice.m_guiStorageSlot = guiStorageSlot;
-            }
-
-            /* Append or break if necessary: */
-            if (fSuccess)
-                guiStorageDevices << guiStorageDevice;
-            else
-                break;
+            const StorageSlot guiStorageSlot(enmStorageBus, iPort, iDevice);
+            guiStorageDevice.m_guiStorageSlot = guiStorageSlot;
+            guiStorageDevices << guiStorageDevice;
         }
     }