Changeset 107692 in vbox for trunk/src

Timestamp:

Jan 10, 2025 4:46:13 PM (10 days ago)

Author:

vboxsync

Message:

src/VBox/Devices/Audio/DrvHostAudioCoreAudio.cpp: Fixed warnings found by Parfait (unused assignment). Don't leak crit sect on CFGM errors. jiraref:VBP-1424

File:

• trunk/src/VBox/Devices/Audio/DrvHostAudioCoreAudio.cpp (modified) (4 diffs)

trunk/src/VBox/Devices/Audio/DrvHostAudioCoreAudio.cpp

@@ -2775 +2775 @@
     pThis->IHostAudio.pfnStreamCapture              = drvHstAudCaHA_StreamCapture;
 
-    int rc = RTCritSectInit(&pThis->CritSect);
-    AssertRCReturn(rc, rc);
-
     /*
      * Validate and read configuration.
@@ -2784 +2781 @@
 
     char *pszTmp = NULL;
-    rc = pHlp->pfnCFGMQueryStringAlloc(pCfg, "InputDeviceID", &pszTmp);
+    int rc = pHlp->pfnCFGMQueryStringAlloc(pCfg, "InputDeviceID", &pszTmp);
     if (RT_SUCCESS(rc))
     {
         rc = drvHstAudCaSetDevice(pThis, &pThis->InputDevice, true /*fInput*/, false /*fNotify*/, pszTmp);
+        if (RT_FAILURE(rc))
+            LogRel(("CoreAudio: Failed to set input device to '%s' (%Rrc)\n", pszTmp, rc));
         PDMDrvHlpMMHeapFree(pDrvIns, pszTmp);
     }
@@ -2797 +2796 @@
     {
         rc = drvHstAudCaSetDevice(pThis, &pThis->OutputDevice, false /*fInput*/, false /*fNotify*/, pszTmp);
+        if (RT_FAILURE(rc))
+            LogRel(("CoreAudio: Failed to set output device to '%s' (%Rrc)\n", pszTmp, rc));
         PDMDrvHlpMMHeapFree(pDrvIns, pszTmp);
     }
@@ -2807 +2808 @@
     pThis->pIHostAudioPort = PDMIBASE_QUERY_INTERFACE(pDrvIns->pUpBase, PDMIHOSTAUDIOPORT);
     AssertReturn(pThis->pIHostAudioPort, VERR_PDM_MISSING_INTERFACE_ABOVE);
+
+    rc = RTCritSectInit(&pThis->CritSect);
+    AssertRCReturn(rc, rc);
 
 #ifdef CORE_AUDIO_WITH_WORKER_THREAD