Changeset 107719 in vbox for trunk

Timestamp:

Jan 13, 2025 6:33:43 PM (4 weeks ago)

Author:

vboxsync

Message:

src/VBox/Additions/common/VBoxService/VBoxServicePropCache.cpp: Fixed warnings found by Parfait (unused assignment). jiraref:VBP-1424

File:

• trunk/src/VBox/Additions/common/VBoxService/VBoxServicePropCache.cpp (modified) (3 diffs)

trunk/src/VBox/Additions/common/VBoxService/VBoxServicePropCache.cpp

@@ -84 +84 @@
     {
         pNode->pszName = RTStrDup(pszName);
-        if (!pNode->pszName)
-        {
-            RTMemFree(pNode);
-            return NULL;
-        }
+        AssertPtrReturnStmt(pNode->pszName, RTMemFree(pNode), NULL);
         pNode->pszValue = NULL;
         pNode->fFlags = 0;
@@ -97 +93 @@
         {
             RTListAppend(&pCache->NodeHead, &pNode->NodeSucc);
-            rc = RTCritSectLeave(&pCache->CritSect);
-        }
-    }
-    return pNode;
+            RTCritSectLeave(&pCache->CritSect);
+
+            return pNode;
+        }
+
+        RTStrFree(pNode->pszName);
+        RTMemFree(pNode);
+    }
+
+    return NULL;
 }
 
@@ -428 +430 @@
 
             if (pNode->fFlags & VGSVCPROPCACHE_FLAGS_TEMPORARY)
-                rc = vgsvcPropCacheWritePropF(pCache->uClientID, pNode->pszName, pNode->fFlags, pNode->pszValueReset);
+                vgsvcPropCacheWritePropF(pCache->uClientID, pNode->pszName, pNode->fFlags, pNode->pszValueReset);
 
             AssertPtr(pNode->pszName);