Changeset 107721 in vbox

Timestamp:

Jan 13, 2025 7:18:55 PM (4 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

166823

Message:

src/VBox/Runtime/r3/ftp-server.cpp: Fixed warnings found by Parfait (unused assignment + unread variable). jiraref:VBP-1424

File:

• trunk/src/VBox/Runtime/r3/ftp-server.cpp (modified) (3 diffs)

trunk/src/VBox/Runtime/r3/ftp-server.cpp

@@ -1318 +1318 @@
 
             if (RT_SUCCESS(rc))
+            {
                 rc = rtFtpSetCWD(&pClient->State, pszPath);
+                if (RT_SUCCESS(rc))
+                    rc = rtFtpServerSendReplyRc(pClient, RTFTPSERVER_REPLY_OKAY);
+            }
 
             RTStrFree(pszPath);
 
-            rc = rtFtpServerSendReplyRc(pClient, RTFTPSERVER_REPLY_OKAY);
         }
         else
@@ -1445 +1448 @@
     int32_t offUtc = Time.offUTC;
     Assert(offUtc <= 840 && offUtc >= -840);
-    char     chSign;
-    if (offUtc >= 0)
-        chSign = '+';
-    else
-    {
-        chSign = '-';
+    if (offUtc < 0)
         offUtc = -offUtc;
-    }
     uint32_t offUtcHour   = (uint32_t)offUtc / 60;
     uint32_t offUtcMinute = (uint32_t)offUtc % 60;
@@ -2430 +2427 @@
             {
                 AssertBreakStmt(cbRead <= sizeof(szCmd), rc = VERR_BUFFER_OVERFLOW);
-                rc = rtFtpServerProcessCommands(pClient, szCmd, cbRead);
+                /* rc ignored, keep going */ rtFtpServerProcessCommands(pClient, szCmd, cbRead);
             }
         }