Changeset 107792 in vbox for trunk/src/VBox/Devices/Network

Timestamp:

Jan 15, 2025 4:15:30 PM (4 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

166931

Message:

Devices/Network/DevE1000.cpp: Convert redundant condition in if into a debug assertion, cbFrame is at least 14 bytes at this point due to a check before, bugref:3409

File:

• trunk/src/VBox/Devices/Network/DevE1000.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Network/DevE1000.cpp

@@ -4221 +4221 @@
 
     /* Add VLAN tag */
-    if (cbFrame > 12 && pThis->fVTag && pSg->cbUsed + 4 <= pSg->cbAvailable)
-    {
+    if (pThis->fVTag && pSg->cbUsed + 4 <= pSg->cbAvailable)
+    {
+        Assert(cbFrame > 12);
+
         E1kLog3(("%s Inserting VLAN tag %08x\n",
             pThis->szPrf, RT_BE2H_U16((uint16_t)VET) | (RT_BE2H_U16(pThis->u16VTagTCI) << 16)));