Changeset 107809 in vbox for trunk/src/VBox/VMM

Timestamp:

Jan 16, 2025 10:42:42 AM (3 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

166964

Message:

VMM: bugref:10759 Don't route setting/clearing of external interrupts via the APIC when no APIC is present.

File:

• trunk/src/VBox/VMM/VMMR3/PDMDevMiscHlp.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMR3/PDMDevMiscHlp.cpp

@@ -69 +69 @@
 #ifdef VBOX_VMM_TARGET_X86
     PVMCPU pVCpu = pVM->apCpusR3[0];  /* for PIC we always deliver to CPU 0, SMP uses APIC */
-    PDMApicSetLocalInterrupt(pVCpu, 0 /* u8Pin */, 1 /* u8Level */, VINF_SUCCESS /* rcRZ */);
+    if (pVM->pdm.s.Ic.pDevInsR3)
+        PDMApicSetLocalInterrupt(pVCpu, 0 /* u8Pin */, 1 /* u8Level */, VINF_SUCCESS /* rcRZ */);
+    else
+        VMCPU_FF_SET(pVCpu, VMCPU_FF_INTERRUPT_PIC);
 #else
     AssertReleaseFailed();
@@ -88 +91 @@
 #ifdef VBOX_VMM_TARGET_X86
     PVMCPU pVCpu = pVM->apCpusR3[0];  /* for PIC we always deliver to CPU 0, SMP uses APIC */
-    PDMApicSetLocalInterrupt(pVCpu, 0 /* u8Pin */,  0 /* u8Level */, VINF_SUCCESS /* rcRZ */);
+    if (pVM->pdm.s.Ic.pDevInsR3)
+        PDMApicSetLocalInterrupt(pVCpu, 0 /* u8Pin */,  0 /* u8Level */, VINF_SUCCESS /* rcRZ */);
+    else
+        VMCPU_FF_CLEAR(pVCpu, VMCPU_FF_INTERRUPT_PIC);
 #else
     AssertReleaseFailed();