Changeset 107850 in vbox for trunk/src/VBox/Devices/Storage

Timestamp:

Jan 17, 2025 4:54:11 PM (4 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

167048

Message:

DevATA: Avoid several Parfait pedantic complaints.

File:

• trunk/src/VBox/Devices/Storage/DevATA.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Storage/DevATA.cpp

@@ -1663 +1663 @@
         {
             /* LBA48 */
-            s->uATARegHCylHOB = iLBA >> 40;
-            s->uATARegLCylHOB = iLBA >> 32;
-            s->uATARegSectorHOB = iLBA >> 24;
-            s->uATARegHCyl = iLBA >> 16;
-            s->uATARegLCyl = iLBA >> 8;
-            s->uATARegSector = iLBA;
+            s->uATARegHCylHOB   = RT_BYTE6(iLBA);
+            s->uATARegLCylHOB   = RT_BYTE5(iLBA);
+            s->uATARegSectorHOB = RT_BYTE4(iLBA);
+            s->uATARegHCyl      = RT_BYTE3(iLBA);
+            s->uATARegLCyl      = RT_BYTE2(iLBA);
+            s->uATARegSector    = RT_BYTE1(iLBA);
         }
         else
@@ -1674 +1674 @@
             /* LBA */
             s->uATARegSelect = (s->uATARegSelect & 0xf0) | (iLBA >> 24);
-            s->uATARegHCyl = (iLBA >> 16);
-            s->uATARegLCyl = (iLBA >> 8);
-            s->uATARegSector = (iLBA);
+            s->uATARegHCyl   = RT_BYTE3(iLBA);
+            s->uATARegLCyl   = RT_BYTE2(iLBA);
+            s->uATARegSector = RT_BYTE1(iLBA);
         }
     }