Changeset 107867 in vbox for trunk/src/VBox/Main

Timestamp:

Jan 21, 2025 6:29:59 AM (4 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

167074

Message:

bugref:10806. Revised the functions updateLastAccessTime() and initIdleTime().

Location:

trunk/src/VBox/Main

Files:

• include/ObjectsTracker.h (modified) (1 diff)
• src-all/ObjectsTracker.cpp (modified) (4 diffs)

trunk/src/VBox/Main/include/ObjectsTracker.h

@@ -155 +155 @@
     }
 
-    com::Utf8Str updateLastAccessTime();
-    com::Utf8Str initIdleTime();
+    RTTIMESPEC updateLastAccessTime();
+    RTTIMESPEC initIdleTime();
     com::Utf8Str creationTimeStr() const;
     TrackedObjectState_T deletionTime(PRTTIMESPEC aTime) const;

trunk/src/VBox/Main/src-all/ObjectsTracker.cpp

@@ -276 +276 @@
 }
 
-com::Utf8Str TrackedObjectData::updateLastAccessTime()
+RTTIMESPEC TrackedObjectData::updateLastAccessTime()
 {
     RTTimeNow(&m_lastAccessTime);
-
-    char szTime[RTTIME_STR_LEN];
-    RTTimeSpecToString(&m_lastAccessTime, szTime, sizeof(szTime));
-    return com::Utf8Str(szTime);
-}
-
-/** @todo r=bird: why on earth does this return a string? */
-com::Utf8Str TrackedObjectData::initIdleTime()
+    return m_lastAccessTime;
+}
+
+RTTIMESPEC TrackedObjectData::initIdleTime()
 {
     if (!m_fIdleTimeStart)
@@ -297 +293 @@
     }
 
-    char szTime[RTTIME_STR_LEN];
-    RTTimeSpecToString(&m_idleTimeStart, szTime, sizeof(szTime));
-    return com::Utf8Str(szTime);
+    return m_idleTimeStart;
 }
 
@@ -562 +556 @@
         {
             /* Update some fields in the found object if needed. in instance, the last access time */
-            com::Utf8Str lat = pIter->second.updateLastAccessTime(); /* Update the access time */
-            Log2(("The updated last access time is %s\n", lat.c_str()));
+            RTTIMESPEC lat = pIter->second.updateLastAccessTime(); /* Update the access time */
+            char szTime[RTTIME_STR_LEN];
+            RTTimeSpecToString(&lat, szTime, sizeof(szTime));
+            Log2(("The updated last access time is %s\n", szTime));
         }
         hrc = S_OK;
@@ -609 +605 @@
     {
         /* Init idle time only once, next time returns the initialization time */
-        com::Utf8Str strTime = pIter->second.initIdleTime();
-        Log2(("The idle time start is %s\n", strTime.c_str()));
+        RTTIMESPEC idleTime = pIter->second.initIdleTime();
+        char szTime[RTTIME_STR_LEN];
+        RTTimeSpecToString(&idleTime, szTime, sizeof(szTime));
+        Log2(("The idle time start is %s\n", szTime));
         vrc = VINF_SUCCESS;
     }