Changeset 107886 in vbox for trunk/src

Timestamp:

Jan 22, 2025 10:55:54 AM (4 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

167100

Message:

Frontends/VBoxManage/VBoxManageMisc.cpp: Fixed warnings found by Parfait (unused assignment + unread variable). jiraref:VBP-1424

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManageMisc.cpp (modified) (7 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageMisc.cpp

@@ -240 +240 @@
                         RTEXITCODE_FAILURE);
 
-        hrc = showProgress(pProgress);
+        showProgress(pProgress);
         CHECK_PROGRESS_ERROR_RET(pProgress, (Misc::tr("Machine delete failed")), RTEXITCODE_FAILURE);
     }
@@ -253 +253 @@
             IMedium *pMedium = aMedia[i];
             if (pMedium)
-                hrc = pMedium->Close();
-        }
-        hrc = S_OK; /** @todo r=andy Why overwriting the result from closing the medium above? */
+                pMedium->Close();
+        }
+
+        hrc = S_OK; /* See comment above, so just set success here. */
     }
     return RTEXITCODE_SUCCESS;
@@ -547 +548 @@
                                progress.asOutParam()),
                         RTEXITCODE_FAILURE);
-        hrc = showProgress(progress);
+        showProgress(progress);
         CHECK_PROGRESS_ERROR_RET(progress, (Misc::tr("Move VM failed")), RTEXITCODE_FAILURE);
 
@@ -759 +760 @@
                                         progress.asOutParam()),
                     RTEXITCODE_FAILURE);
-    hrc = showProgress(progress);
+    showProgress(progress);
     CHECK_PROGRESS_ERROR_RET(progress, (Misc::tr("Clone VM failed")), RTEXITCODE_FAILURE);
 
@@ -2007 +2008 @@
     RTGETOPTUNION   ValueUnion;
     int             ch;
-    HRESULT         hrc = S_OK;
 
     if (!strcmp(a->argv[0], "install"))
@@ -2096 +2096 @@
         ComPtr<IProgress> ptrProgress;
         CHECK_ERROR2I_RET(ptrExtPackFile, Install(fReplace, NULL, ptrProgress.asOutParam()), RTEXITCODE_FAILURE);
-        hrc = showProgress(ptrProgress);
+        showProgress(ptrProgress);
         CHECK_PROGRESS_ERROR_RET(ptrProgress, (Misc::tr("Failed to install \"%s\""), szPath), RTEXITCODE_FAILURE);
 
@@ -2137 +2137 @@
         ComPtr<IProgress> ptrProgress;
         CHECK_ERROR2I_RET(ptrExtPackMgr, Uninstall(bstrName.raw(), fForced, NULL, ptrProgress.asOutParam()), RTEXITCODE_FAILURE);
-        hrc = showProgress(ptrProgress);
+        showProgress(ptrProgress);
         CHECK_PROGRESS_ERROR_RET(ptrProgress, (Misc::tr("Failed to uninstall \"%s\""), pszName), RTEXITCODE_FAILURE);