Changeset 107887 in vbox

Timestamp:

Jan 22, 2025 11:02:17 AM (2 weeks ago)

Author:

vboxsync

Message:

GuestHost/installation/VBoxWinDrvInst.cpp: Fixed warnings found by Parfait (unused assignment + unused function). jiraref:VBP-1424

File:

• trunk/src/VBox/GuestHost/installation/VBoxWinDrvInst.cpp (modified) (4 diffs)

trunk/src/VBox/GuestHost/installation/VBoxWinDrvInst.cpp

@@ -283 +283 @@
 }
 
+#if 0 /* Unused */
 /**
  * Logs an error message but ignores (skips) the error count.
@@ -317 +318 @@
     return rc;
 }
+#endif /* Unused */
 
 /**
@@ -1394 +1396 @@
                     rc = vboxWinDrvInstLogLastError(pCtx, "GetFullPathNameW() failed");
 
-                rc = vboxWinDrvTryInfSection(pCtx,
-                                             pParms->pwszInfFile, pParms->u.UnInstall.pwszSection,
-                                             vboxWinDrvInstallTryInfSectionCallback);
+                if (RT_SUCCESS(rc))
+                    rc = vboxWinDrvTryInfSection(pCtx,
+                                                 pParms->pwszInfFile, pParms->u.UnInstall.pwszSection,
+                                                 vboxWinDrvInstallTryInfSectionCallback);
             }
 
@@ -2204 +2207 @@
     if (RT_SUCCESS(rc) && pszSection) /* pszSection is optional. */
         rc = RTStrToUtf16(pszSection, &pCtx->Parms.u.ExecuteInf.pwszSection);
+    AssertRCReturn(rc, rc);
 
     pCtx->Parms.enmMode = fInstall ? VBOXWINDRVINSTMODE_INSTALL_INFSECTION : VBOXWINDRVINSTMODE_UNINSTALL_INFSECTION;