Changeset 107978 in vbox

Timestamp:

Jan 29, 2025 11:51:23 AM (3 weeks ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

167241

Message:

FE/Qt: bugref:10814: VBox Manager / Tools pane: Cleanup in tool item basic stuff.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/manager/tools

Files:

• UIToolsItem.cpp (modified) (7 diffs)
• UIToolsItem.h (modified) (1 diff)
• UIToolsModel.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/manager/tools/UIToolsItem.cpp

@@ -211 +211 @@
     , m_iMaximumNameWidth(0)
 {
-    /* Prepare: */
     prepare();
 }
@@ -217 +216 @@
 UIToolsItem::~UIToolsItem()
 {
-    /* Cleanup: */
     cleanup();
 }
@@ -228 +226 @@
 }
 
-void UIToolsItem::reconfigure(const QString &strName)
-{
-    /* If name is changed: */
+void UIToolsItem::setName(const QString &strName)
+{
+    /* If name changed: */
     if (m_strName != strName)
     {
@@ -238 +236 @@
         updateVisibleName();
     }
-}
-
-UIToolClass UIToolsItem::itemClass() const
-{
-    return m_enmClass;
-}
-
-UIToolType UIToolsItem::itemType() const
-{
-    return m_enmType;
-}
-
-const QIcon &UIToolsItem::icon() const
-{
-    return m_icon;
-}
-
-const QString &UIToolsItem::name() const
-{
-    return m_strName;
 }
 
@@ -276 +254 @@
     else
         emit sigHoverLeave();
-}
-
-bool UIToolsItem::isHovered() const
-{
-    return m_fHovered;
 }
 
@@ -390 +363 @@
         update();
 
-        /* Show text at the right of item: */
+        /* Show tooltip at the right of item for widget mode: */
         if (!model()->tools()->isPopup())
         {
@@ -408 +381 @@
         update();
 
-        /* Hide text for good: */
+        /* Hide tooltip for good: */
         if (!model()->tools()->isPopup())
             QToolTip::hideText();

trunk/src/VBox/Frontends/VirtualBox/src/manager/tools/UIToolsItem.h

@@ -100 +100 @@
         UIToolsModel *model() const;
 
-        /** Reconfigures item with @a strName. */
-        void reconfigure(const QString &strName);
+        /** Returns item name. */
+        QString name() const { return m_strName; }
+        /** Defines item @a strName. */
+        void setName(const QString &strName);
+
+        /** Returns item icon. */
+        QIcon icon() const { return m_icon; }
 
         /** Returns item class. */
-        UIToolClass itemClass() const;
+        UIToolClass itemClass() const { return m_enmClass; }
         /** Returns item type. */
-        UIToolType itemType() const;
-        /** Returns item icon. */
-        const QIcon &icon() const;
-        /** Returns item name. */
-        const QString &name() const;
+        UIToolType itemType() const { return m_enmType; }
 
         /** Defines whether item is @a fEnabled. */
         void setEnabled(bool fEnabled);
 
+        /** Returns whether item is hovered. */
+        bool isHovered() const { return m_fHovered; }
         /** Defines whether item is @a fHovered. */
         void setHovered(bool fHovered);
-        /** Returns whether item is hovered. */
-        bool isHovered() const;
     /** @} */
 

trunk/src/VBox/Frontends/VirtualBox/src/manager/tools/UIToolsModel.cpp

@@ -443 +443 @@
         switch (pItem->itemType())
         {
-            case UIToolType_Welcome:     pItem->reconfigure(tr("Welcome")); break;
-            case UIToolType_Extensions:  pItem->reconfigure(tr("Extensions")); break;
-            case UIToolType_Media:       pItem->reconfigure(tr("Media")); break;
-            case UIToolType_Network:     pItem->reconfigure(tr("Network")); break;
-            case UIToolType_Cloud:       pItem->reconfigure(tr("Cloud")); break;
-            case UIToolType_Activities:  pItem->reconfigure(tr("Activities")); break;
+            case UIToolType_Welcome:     pItem->setName(tr("Welcome")); break;
+            case UIToolType_Extensions:  pItem->setName(tr("Extensions")); break;
+            case UIToolType_Media:       pItem->setName(tr("Media")); break;
+            case UIToolType_Network:     pItem->setName(tr("Network")); break;
+            case UIToolType_Cloud:       pItem->setName(tr("Cloud")); break;
+            case UIToolType_Activities:  pItem->setName(tr("Activities")); break;
 #ifdef VBOX_GUI_WITH_ADVANCED_WIDGETS
-            case UIToolType_Machines:    pItem->reconfigure(tr("Machines")); break;
+            case UIToolType_Machines:    pItem->setName(tr("Machines")); break;
 #endif
-            case UIToolType_Details:     pItem->reconfigure(tr("Details")); break;
-            case UIToolType_Snapshots:   pItem->reconfigure(tr("Snapshots")); break;
-            case UIToolType_Logs:        pItem->reconfigure(tr("Logs")); break;
-            case UIToolType_VMActivity:  pItem->reconfigure(tr("Activity")); break;
-            case UIToolType_FileManager: pItem->reconfigure(tr("File Manager")); break;
+            case UIToolType_Details:     pItem->setName(tr("Details")); break;
+            case UIToolType_Snapshots:   pItem->setName(tr("Snapshots")); break;
+            case UIToolType_Logs:        pItem->setName(tr("Logs")); break;
+            case UIToolType_VMActivity:  pItem->setName(tr("Activity")); break;
+            case UIToolType_FileManager: pItem->setName(tr("File Manager")); break;
             default: break;
         }