Changeset 108003 in vbox for trunk

Timestamp:

Jan 31, 2025 2:05:57 PM (3 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

167275

Message:

Parfait: fixed the warning "Change of signedness on implicit conversion" in VBoxManage part of the code

Location:

trunk/src/VBox/Frontends/VBoxManage

Files:

• VBoxManage.cpp (modified) (2 diffs)
• VBoxManageAppliance.cpp (modified) (2 diffs)
• VBoxManageControlVM.cpp (modified) (1 diff)
• VBoxManageDebugVM.cpp (modified) (2 diffs)
• VBoxManageDisk.cpp (modified) (7 diffs)
• VBoxManageGuestCtrl.cpp (modified) (2 diffs)
• VBoxManageGuestProp.cpp (modified) (1 diff)
• VBoxManageInfo.cpp (modified) (5 diffs)
• VBoxManageList.cpp (modified) (3 diffs)
• VBoxManageMetrics.cpp (modified) (3 diffs)
• VBoxManageMisc.cpp (modified) (3 diffs)
• VBoxManageModifyVM.cpp (modified) (7 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManage.cpp

@@ -486 +486 @@
 
     /* complete the line. */
-    LONG iRc = E_FAIL;
+    LONG iRc = (LONG)E_FAIL;
     hrc = progress->COMGETTER(ResultCode)(&iRc);
     if (SUCCEEDED(hrc))
@@ -510 +510 @@
                 RTStrmPrintf(g_pStdErr, "%Rhrc\n", iRc);
         }
-        hrc = iRc;
+        hrc = (HRESULT)iRc;
     }
     else

trunk/src/VBox/Frontends/VBoxManage/VBoxManageAppliance.cpp

@@ -106 +106 @@
         const char *pszComma = strchr(psz, ',');
         if (pszComma)
-            len = pszComma - psz;
+            len = (size_t)(pszComma - psz);
         else
             len = strlen(psz);
@@ -1464 +1464 @@
         const char *pszComma = strchr(psz, ',');
         if (pszComma)
-            len = pszComma - psz;
+            len = (size_t)(pszComma - psz);
         else
             len = strlen(psz);

trunk/src/VBox/Frontends/VBoxManage/VBoxManageControlVM.cpp

@@ -1557 +1557 @@
 
                     aChangeOrigin = TRUE;
-                    aOriginX      = RTStrToUInt32(argv[2]);
-                    aOriginY      = RTStrToUInt32(argv[3]);
+                    aOriginX      = (LONG)RTStrToUInt32(argv[2]);/* Explicit conversion */
+                    aOriginY      = (LONG)RTStrToUInt32(argv[3]);/* Explicit conversion */
                     aWidth        = RTStrToUInt32(argv[4]);
                     aHeight       = RTStrToUInt32(argv[5]);

trunk/src/VBox/Frontends/VBoxManage/VBoxManageDebugVM.cpp

@@ -462 +462 @@
                 try
                 {
-                    com::Bstr bstrName(ValueUnion.psz, pszEqual - ValueUnion.psz);
+                    com::Bstr bstrName(ValueUnion.psz, (size_t)(pszEqual - ValueUnion.psz));
                     com::Bstr bstrValue(pszEqual + 1);
                     if (   !aBstrNames.push_back(bstrName.raw())
@@ -851 +851 @@
     ComPtr<IProgress> ptrProgress;
     com::Bstr bstrFilename(pszFilename);
-    CHECK_ERROR2I_RET(pDebugger, TakeGuestSample(bstrFilename.raw(), cSampleIntervalUs, cSampleTimeUs, ptrProgress.asOutParam()), RTEXITCODE_FAILURE);
+    CHECK_ERROR2I_RET(pDebugger, TakeGuestSample(bstrFilename.raw(), cSampleIntervalUs, (LONG64)cSampleTimeUs, ptrProgress.asOutParam()), RTEXITCODE_FAILURE);
     showProgress(ptrProgress);
 

trunk/src/VBox/Frontends/VBoxManage/VBoxManageDisk.cpp

@@ -84 +84 @@
         const char *pszComma = strchr(psz, ',');
         if (pszComma)
-            len = pszComma - psz;
+            len = (size_t)(pszComma - psz);
         else
             len = strlen(psz);
@@ -622 +622 @@
 
         if (fBase)
-            CHECK_ERROR(pMedium, CreateBaseStorage(size, ComSafeArrayAsInParam(l_variants), pProgress.asOutParam()));
+            CHECK_ERROR(pMedium, CreateBaseStorage((LONG64)size, ComSafeArrayAsInParam(l_variants), pProgress.asOutParam()));
         else
             CHECK_ERROR(pParentMedium, CreateDiffStorage(pMedium, ComSafeArrayAsInParam(l_variants), pProgress.asOutParam()));
@@ -929 +929 @@
     {
         ComPtr<IProgress> pProgress;
-        CHECK_ERROR(pMedium, Resize(cbResize, pProgress.asOutParam()));
+        CHECK_ERROR(pMedium, Resize((LONG64)cbResize, pProgress.asOutParam()));
         if (SUCCEEDED(hrc))
             hrc = showProgress(pProgress);
@@ -1197 +1197 @@
         if (fNeedResize)
         {
-            CHECK_ERROR_BREAK(pSrcMedium, ResizeAndCloneTo(pDstMedium, cbResize, ComSafeArrayAsInParam(l_variants), NULL, pProgress.asOutParam()));
+            CHECK_ERROR_BREAK(pSrcMedium, ResizeAndCloneTo(pDstMedium, (LONG64)cbResize, ComSafeArrayAsInParam(l_variants), NULL, pProgress.asOutParam()));
         }
         else
@@ -2289 +2289 @@
             LONG64 cbLogical = 0;
             CHECK_ERROR2I_STMT(ptrMedium, COMGETTER(LogicalSize)(&cbLogical), hrc = hrcCheck);
-            *pcbMedium = cbLogical;
+            *pcbMedium = (uint64_t)cbLogical;
             if (!SUCCEEDED(hrc))
                 rPtrMediumIO.setNull();
@@ -2457 +2457 @@
                 uint32_t const  cbToRead = (uint32_t)RT_MIN(cb, _128K);
                 SafeArray<BYTE> SafeArrayBuf;
-                HRESULT hrc = ptrMediumIO->Read(off, cbToRead, ComSafeArrayAsOutParam(SafeArrayBuf));
+                HRESULT hrc = ptrMediumIO->Read((LONG64)off, cbToRead, ComSafeArrayAsOutParam(SafeArrayBuf));
                 if (FAILED(hrc))
                 {
@@ -2514 +2514 @@
                                 {
                                     uint8_t const u8 = pbBuf[i];
-                                    szLine[cch++] = u8 < 127 && u8 >= 32 ? u8 : '.';
+                                    szLine[cch++] = u8 < 127 && u8 >= 32 ? (char)u8 : '.';
                                 }
                                 szLine[cch++] = '\n';

trunk/src/VBox/Frontends/VBoxManage/VBoxManageGuestCtrl.cpp

@@ -1566 +1566 @@
                                  lExitCode, procStatus, gctlProcessStatusToText(procStatus));
 
-                    rcExit = gctlRunCalculateExitCode(procStatus, lExitCode, true /*fReturnExitCodes*/);
+                    rcExit = gctlRunCalculateExitCode(procStatus, (ULONG)lExitCode, true /*fReturnExitCodes*/);
                 }
                 else if (   procStatus == ProcessStatus_TimedOutKilled
@@ -1704 +1704 @@
 
     char **papszSources = RTGetOptNonOptionArrayPtr(&GetState);
-    size_t cSources = &argv[argc] - papszSources;
+    size_t cSources = (size_t)(&argv[argc] - papszSources);
 
     if (!cSources)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageGuestProp.cpp

@@ -512 +512 @@
 
         ComPtr<IEvent> ev;
-        hrc = es->GetEvent(listener, cMsWait, ev.asOutParam());
+        hrc = es->GetEvent(listener, (LONG)cMsWait, ev.asOutParam());
         if (ev) /** @todo r=andy Why not using SUCCEEDED(hrc) here? */
         {

trunk/src/VBox/Frontends/VBoxManage/VBoxManageInfo.cpp

@@ -339 +339 @@
     RTTimeExplode(&t, &ts);
 
-    RTStrPrintf(s, cb, "%04d/%02d/%02d %02d:%02d:%02d UTC",
+    RTStrPrintf(s, (size_t)cb, "%04d/%02d/%02d %02d:%02d:%02d UTC",
                         t.i32Year, t.u8Month, t.u8MonthDay,
                         t.u8Hour, t.u8Minute, t.u8Second);
@@ -487 +487 @@
             break;
         }
-        RTStrmWrite(g_pStdOut, psz, pszNext - psz);
+        RTStrmWrite(g_pStdOut, psz, (size_t)(pszNext - psz));
         char const szTmp[2] = { '\\', *pszNext };
         RTStrmWrite(g_pStdOut, szTmp, sizeof(szTmp));
@@ -910 +910 @@
         {
             ComPtr<IMediumAttachment> mediumAttach;
-            HRESULT hrc = machine->GetMediumAttachment(bstrStorageCtlName.raw(), i, k, mediumAttach.asOutParam());
+            HRESULT hrc = machine->GetMediumAttachment(bstrStorageCtlName.raw(), (LONG)i, (LONG)k, mediumAttach.asOutParam());
             if (!SUCCEEDED(hrc) && hrc != VBOX_E_OBJECT_NOT_FOUND)
             {
@@ -934 +934 @@
 
             ComPtr<IMedium> medium;
-            hrc = machine->GetMedium(bstrStorageCtlName.raw(), i, k, medium.asOutParam());
+            hrc = machine->GetMedium(bstrStorageCtlName.raw(), (LONG)i, (LONG)k, medium.asOutParam());
             if (SUCCEEDED(hrc) && medium)
             {
@@ -3277 +3277 @@
             aLogData.setNull();
             /* Fetch a chunk of the log file */
-            CHECK_ERROR_BREAK(machine, ReadLog(uLogIdx, uOffset, _1M,
+            CHECK_ERROR_BREAK(machine, ReadLog(uLogIdx, (LONG64)uOffset, _1M,
                                                ComSafeArrayAsOutParam(aLogData)));
             cbLogData = aLogData.size();

trunk/src/VBox/Frontends/VBoxManage/VBoxManageList.cpp

@@ -1026 +1026 @@
     RTPrintf(List::tr("Maximum guest CPU count:         %u\n"), ulValue);
     systemProperties->COMGETTER(InfoVDSize)(&i64Value);
-    RTPrintf(List::tr("Virtual disk limit (info):       %lld Bytes\n", "" , i64Value), i64Value);
+    RTPrintf(List::tr("Virtual disk limit (info):       %lld Bytes\n", "" , (size_t)i64Value), i64Value);
 
 #if 0
@@ -1565 +1565 @@
     {
         uint32_t u32Format = (uint32_t)formats[i];
-        char szFormat[5];
+        unsigned char szFormat[5];
         szFormat[0] = RT_BYTE1(u32Format);
         szFormat[1] = RT_BYTE2(u32Format);
@@ -1980 +1980 @@
         hrc = pHostDrive->COMGETTER(Size)(&cbSize);
         if (SUCCEEDED(hrc) && fOptLong)
-            RTPrintf(List::tr("Size:        %llu bytes (%Rhcb)\n", "", cbSize), cbSize, cbSize);
+            RTPrintf(List::tr("Size:        %llu bytes (%Rhcb)\n", "", (size_t)cbSize), cbSize, cbSize);
         else if (SUCCEEDED(hrc))
             RTPrintf(List::tr("Size:        %Rhcb\n"), cbSize);

trunk/src/VBox/Frontends/VBoxManage/VBoxManageMetrics.cpp

@@ -411 +411 @@
     bool isDetached = false, listMatches = false;
     int i;
-
     setCurrentSubcommand(HELP_SCOPE_METRICS_COLLECT);
 
@@ -460 +459 @@
     ComPtr<IUnknown> objectFiltered;
     Bstr metricNameFiltered;
-    for (i = 0; i < (int)metricInfo.size(); i++)
-    {
-        CHECK_ERROR(metricInfo[i], COMGETTER(Object)(objectFiltered.asOutParam()));
-        CHECK_ERROR(metricInfo[i], COMGETTER(MetricName)(metricNameFiltered.asOutParam()));
+
+    for (size_t j = 0; j < metricInfo.size(); j++)
+    {
+        CHECK_ERROR(metricInfo[j], COMGETTER(Object)(objectFiltered.asOutParam()));
+        CHECK_ERROR(metricInfo[j], COMGETTER(MetricName)(metricNameFiltered.asOutParam()));
         Utf8Str baseMetricName(metricNameFiltered);
         baseMetrics.insert(std::make_pair(objectFiltered, toBaseName(baseMetricName)));
@@ -470 +470 @@
     com::SafeIfaceArray<IUnknown> objectsFiltered(baseMetrics.size());
     std::set<std::pair<ComPtr<IUnknown>,Bstr> >::iterator it;
-    i = 0;
+
+    size_t n = 0;
     for (it = baseMetrics.begin(); it != baseMetrics.end(); ++it)
     {
-        it->first.queryInterfaceTo(&objectsFiltered[i]);
-        Bstr(it->second).detachTo(&baseMetricsFiltered[i++]);
+        it->first.queryInterfaceTo(&objectsFiltered[n]);
+        Bstr(it->second).detachTo(&baseMetricsFiltered[n++]);
     }
     com::SafeIfaceArray<IPerformanceMetric> affectedMetrics;

trunk/src/VBox/Frontends/VBoxManage/VBoxManageMisc.cpp

@@ -595 +595 @@
         const char *pszComma = strchr(psz, ',');
         if (pszComma)
-            len = pszComma - psz;
+            len = (size_t)(pszComma - psz);
         else
             len = strlen(psz);
@@ -943 +943 @@
                                     com::GluePrintErrorInfo(info);
                                 }
-                                hrc = iRc;
+                                hrc = (HRESULT)iRc;
                             }
                         }
@@ -2708 +2708 @@
                             com::GluePrintErrorInfo(info);
                         }
-                        hrc = iRc;
+                        hrc = (HRESULT)iRc;
                     }
                 }

trunk/src/VBox/Frontends/VBoxManage/VBoxManageModifyVM.cpp

@@ -603 +603 @@
         if (pComma)
         {
-            Bstr(pcszGroups, pComma - pcszGroups).detachTo(pGroups->appendedRaw());
+            Bstr(pcszGroups, (size_t)(pComma - pcszGroups)).detachTo(pGroups->appendedRaw());
             pcszGroups = pComma + 1;
         }
@@ -656 +656 @@
     if (   uIndex >= 1
         && uIndex <= cMaxIndex)
-        return uIndex;
+        return (int)uIndex;
     errorArgument(ModifyVM::tr("Invalid %s number %u"), pszName, uIndex);
     return 0;
@@ -1308 +1308 @@
                 if (!RTStrICmp(ValueUnion.psz, "none"))
                 {
-                    sessionMachine->DetachDevice(bstrController.raw(), u1, u2);
+                    sessionMachine->DetachDevice(bstrController.raw(), (LONG)u1, (LONG)u2);
                 }
                 else
@@ -1322 +1322 @@
                     {
                         CHECK_ERROR(sessionMachine, AttachDevice(bstrController.raw(),
-                                                          u1, u2,
+                                                          (LONG)u1, (LONG)u2,
                                                           DeviceType_HardDisk,
                                                           hardDisk));
@@ -1391 +1391 @@
                 {
                     hrc = sessionMachine->DetachDevice(Bstr("LsiLogic").raw(),
-                                               GetOptState.uIndex, 0);
+                                               (LONG)GetOptState.uIndex, 0);
                     if (FAILED(hrc))
                         CHECK_ERROR(sessionMachine, DetachDevice(Bstr("BusLogic").raw(),
-                                                          GetOptState.uIndex, 0));
+                                                          (LONG)GetOptState.uIndex, 0));
                 }
                 else
@@ -1408 +1408 @@
                     {
                         hrc = sessionMachine->AttachDevice(Bstr("LsiLogic").raw(),
-                                                   GetOptState.uIndex, 0,
+                                                   (LONG)GetOptState.uIndex, 0,
                                                    DeviceType_HardDisk,
                                                    hardDisk);
@@ -1414 +1414 @@
                             CHECK_ERROR(sessionMachine,
                                         AttachDevice(Bstr("BusLogic").raw(),
-                                                     GetOptState.uIndex, 0,
+                                                     (LONG)GetOptState.uIndex, 0,
                                                      DeviceType_HardDisk,
                                                      hardDisk));