Changeset 108078 in vbox for trunk

Timestamp:

Feb 5, 2025 3:53:15 PM (3 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

167372

Message:

FE/Qt: VM settings dialog: Do not close the dialog if settings saving failed.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/settings/UIAdvancedSettingsDialog.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/settings/UIAdvancedSettingsDialog.cpp

@@ -812 +812 @@
     save();
 
-    /* Close if there is no ongoing serialization: */
-    if (!isSerializationInProgress())
+    /* Close if there is no ongoing serialization
+     * and previous try was successful: */
+    if (   !isSerializationInProgress()
+        && m_fSerializationClean)
         sltClose();
 }
@@ -1574 +1576 @@
         m_pButtonBox->button(QDialogButtonBox::Ok)->setShortcut(Qt::Key_Return);
         m_pButtonBox->button(QDialogButtonBox::Cancel)->setShortcut(Qt::Key_Escape);
-        connect(m_pButtonBox, &QIDialogButtonBox::rejected, this, &UIAdvancedSettingsDialog::sltClose);
+        connect(m_pButtonBox, &QIDialogButtonBox::rejected, this, &UIAdvancedSettingsDialog::reject);
         connect(m_pButtonBox, &QIDialogButtonBox::accepted, this, &UIAdvancedSettingsDialog::accept);
         connect(m_pButtonBox->button(QDialogButtonBox::Help), &QAbstractButton::pressed,