Changeset 108082 in vbox

Timestamp:

Feb 5, 2025 5:37:00 PM (2 weeks ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

167376

Message:

FE/Qt: VM settings dialog / General and System pages: Missing API error handling for all the remaining places.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine

Files:

• UIMachineSettingsGeneral.cpp (modified) (1 diff)
• UIMachineSettingsSystem.cpp (modified) (10 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsGeneral.cpp

@@ -786 +786 @@
                         const CGuestOSType comNewType = gpGlobalSession->virtualBox().GetGuestOSType(newGeneralData.m_strGuestOsTypeId);
                         comPlatformX86.SetCPUProperty(KCPUPropertyTypeX86_LongMode, comNewType.GetIs64Bit());
-                        fSuccess = comPlatformX86.isOk();
-                        /// @todo convey error info ..
+                        if (!comPlatformX86.isOk())
+                        {
+                            notifyOperationProgressError(UIErrorString::formatErrorInfo(comPlatformX86));
+                            return false;
+                        }
                         break;
                     }

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsSystem.cpp

@@ -978 +978 @@
             CPlatform comPlatform = m_machine.GetPlatform();
             comPlatform.SetChipsetType(newSystemData.m_chipsetType);
-            fSuccess = comPlatform.isOk();
-            /// @todo convey error info ..
+            if (!comPlatform.isOk())
+            {
+                notifyOperationProgressError(UIErrorString::formatErrorInfo(comPlatform));
+                return false;
+            }
         }
         /* Save TPM type: */
@@ -986 +989 @@
             CTrustedPlatformModule comModule = m_machine.GetTrustedPlatformModule();
             comModule.SetType(newSystemData.m_tpmType);
-            fSuccess = comModule.isOk();
-            /// @todo convey error info ..
+            if (!comModule.isOk())
+            {
+                notifyOperationProgressError(UIErrorString::formatErrorInfo(comModule));
+                return false;
+            }
         }
         /* Save pointing HID type: */
@@ -1000 +1006 @@
             CFirmwareSettings comFirmwareSettings = m_machine.GetFirmwareSettings();
             comFirmwareSettings.SetIOAPICEnabled(newSystemData.m_fEnabledIoApic);
-            fSuccess = comFirmwareSettings.isOk();
-            /// @todo convey error info ..
+            if (!comFirmwareSettings.isOk())
+            {
+                notifyOperationProgressError(UIErrorString::formatErrorInfo(comFirmwareSettings));
+                return false;
+            }
         }
         /* Save firware type (whether EFI is enabled): */
@@ -1008 +1017 @@
             CFirmwareSettings comFirmwareSettings = m_machine.GetFirmwareSettings();
             comFirmwareSettings.SetFirmwareType(newSystemData.m_fEnabledEFI ? KFirmwareType_EFI : KFirmwareType_BIOS);
-            fSuccess = comFirmwareSettings.isOk();
-            /// @todo convey error info ..
+            if (!comFirmwareSettings.isOk())
+            {
+                notifyOperationProgressError(UIErrorString::formatErrorInfo(comFirmwareSettings));
+                return false;
+            }
         }
         /* Save whether UTC is enabled: */
@@ -1016 +1028 @@
             CPlatform comPlatform = m_machine.GetPlatform();
             comPlatform.SetRTCUseUTC(newSystemData.m_fEnabledUTC);
-            fSuccess = comPlatform.isOk();
-            /// @todo convey error info ..
+            if (!comPlatform.isOk())
+            {
+                notifyOperationProgressError(UIErrorString::formatErrorInfo(comPlatform));
+                return false;
+            }
         }
         /* Save whether secure boot is enabled: */
@@ -1038 +1053 @@
                     /* Init if required: */
                     if (!newSystemData.m_fAvailableSecureBoot)
+                    {
                         comStoreLvl1.InitUefiVariableStore(0);
+                        if (!comStoreLvl1.isOk())
+                        {
+                            notifyOperationProgressError(UIErrorString::formatErrorInfo(comStoreLvl1));
+                            return false;
+                        }
+                    }
                     /* Enroll everything: */
                     comStoreLvl2 = comStoreLvl1.GetUefiVariableStore();
                     comStoreLvl2.EnrollOraclePlatformKey();
+                    if (!comStoreLvl2.isOk())
+                    {
+                        notifyOperationProgressError(UIErrorString::formatErrorInfo(comStoreLvl2));
+                        return false;
+                    }
                     comStoreLvl2.EnrollDefaultMsSignatures();
+                    if (!comStoreLvl2.isOk())
+                    {
+                        notifyOperationProgressError(UIErrorString::formatErrorInfo(comStoreLvl2));
+                        return false;
+                    }
                 }
                 comStoreLvl2.SetSecureBootEnabled(true);
-                fSuccess = comStoreLvl2.isOk();
-                /// @todo convey error info ..
+                if (!comStoreLvl2.isOk())
+                {
+                    notifyOperationProgressError(UIErrorString::formatErrorInfo(comStoreLvl2));
+                    return false;
+                }
             }
             /* Disabling secure boot? */
@@ -1052 +1087 @@
             {
                 comStoreLvl2.SetSecureBootEnabled(false);
-                fSuccess = comStoreLvl2.isOk();
-                /// @todo convey error info ..
+                if (!comStoreLvl2.isOk())
+                {
+                    notifyOperationProgressError(UIErrorString::formatErrorInfo(comStoreLvl2));
+                    return false;
+                }
             }
         }
@@ -1100 +1138 @@
                     {
                         comPlatformX86.SetCPUProperty(KCPUPropertyTypeX86_PAE, newSystemData.m_fEnabledPAE);
-                        fSuccess = comPlatformX86.isOk();
-                        /// @todo convey error info ..
+                        if (!comPlatformX86.isOk())
+                        {
+                            notifyOperationProgressError(UIErrorString::formatErrorInfo(comPlatformX86));
+                            return false;
+                        }
                     }
                     /* Save whether Nested HW Virt Ex is enabled: */
@@ -1107 +1148 @@
                     {
                         comPlatformX86.SetCPUProperty(KCPUPropertyTypeX86_HWVirt, newSystemData.m_fEnabledNestedHwVirtEx);
-                        fSuccess = comPlatformX86.isOk();
-                        /// @todo convey error info ..
+                        if (!comPlatformX86.isOk())
+                        {
+                            notifyOperationProgressError(UIErrorString::formatErrorInfo(comPlatformX86));
+                            return false;
+                        }
                     }
 
@@ -1176 +1220 @@
                     {
                         comPlatformX86.SetHWVirtExProperty(KHWVirtExPropertyType_NestedPaging, newSystemData.m_fEnabledNestedPaging);
-                        fSuccess = comPlatformX86.isOk();
-                        /// @todo convey error info ..
+                        if (!comPlatformX86.isOk())
+                        {
+                            notifyOperationProgressError(UIErrorString::formatErrorInfo(comPlatformX86));
+                            return false;
+                        }
                     }