Changeset 108177 in vbox

Timestamp:

Feb 12, 2025 12:15:35 PM (3 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

167492

Message:

FE/Qt: bugref:10814: VBox Manager / Tool-pane: Update global tool menu restrictions when the Chooser-pane selection got changed; That is required to hide/show Machines tool accordingly, we are not going to show it if there are no VMs.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/manager

Files:

• UIGlobalToolsManagerWidget.cpp (modified) (5 diffs)
• UIGlobalToolsManagerWidget.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/manager/UIGlobalToolsManagerWidget.cpp

@@ -181 +181 @@
 }
 
+void UIGlobalToolsManagerWidget::sltHandleChooserPaneSelectionChange()
+{
+    updateToolsMenu();
+}
+
 void UIGlobalToolsManagerWidget::sltHandleCloudProfileStateChange(const QString &, const QString &)
 {
@@ -254 +259 @@
 
     /* Chooser-pane connections: */
+    connect(chooser(), &UIChooser::sigSelectionChanged,
+            this, &UIGlobalToolsManagerWidget::sltHandleChooserPaneSelectionChange);
     connect(chooser(), &UIChooser::sigCloudProfileStateChange,
             this, &UIGlobalToolsManagerWidget::sltHandleCloudProfileStateChange);
@@ -282 +289 @@
 
     /* Chooser-pane connections: */
+    disconnect(chooser(), &UIChooser::sigSelectionChanged,
+               this, &UIGlobalToolsManagerWidget::sltHandleChooserPaneSelectionChange);
     disconnect(chooser(), &UIChooser::sigCloudProfileStateChange,
                this, &UIGlobalToolsManagerWidget::sltHandleCloudProfileStateChange);
@@ -311 +320 @@
 void UIGlobalToolsManagerWidget::updateToolsMenu()
 {
-    /* Update global tools restrictions: */
+    /* Prepare tool restrictions: */
     QSet<UIToolType> restrictedTypes;
+
     /* Restrict some types for Basic mode: */
     const bool fExpertMode = gEDataManager->isSettingsInExpertMode();
@@ -318 +328 @@
         restrictedTypes << UIToolType_Media
                         << UIToolType_Network;
+
+    /* Make sure Machines tool is hidden for empty Chooser-pane: */
+    if (!chooser()->currentItem())
+        restrictedTypes << UIToolType_Machines;
+
+    /* Make sure no restricted tool is selected: */
     if (restrictedTypes.contains(toolMenu()->toolsType()))
         setMenuToolType(UIToolType_Home);
+
+    /* Hide restricted tools in the menu: */
     const QList restrictions(restrictedTypes.begin(), restrictedTypes.end());
     toolMenu()->setRestrictedToolTypes(restrictions);
 
-    /* Take restrictions into account, closing all restricted tools: */
+    /* Close all restricted tools (besides the Machines): */
     foreach (const UIToolType &enmRestrictedType, restrictedTypes)
-        toolPane()->closeTool(enmRestrictedType);
-}
+        if (enmRestrictedType != UIToolType_Machines)
+            toolPane()->closeTool(enmRestrictedType);
+}

trunk/src/VBox/Frontends/VirtualBox/src/manager/UIGlobalToolsManagerWidget.h

@@ -124 +124 @@
     /** @name Chooser pane stuff.
       * @{ */
+        /** Handles Chooser-pane selection change. */
+        void sltHandleChooserPaneSelectionChange();
+
         /** Handles state change for cloud profile with certain @a strProviderShortName and @a strProfileName. */
         void sltHandleCloudProfileStateChange(const QString &strProviderShortName,