Changeset 108197 in vbox for trunk/src

Timestamp:

Feb 13, 2025 3:25:28 PM (3 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

167515

Message:

FE/Qt: bugref:10814: VBox Manager / Tools pane: Remove focus-item change handler as all items always visible in the tools menu.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/manager/tools

Files:

• UITools.cpp (modified) (2 diffs)
• UIToolsModel.cpp (modified) (2 diffs)
• UIToolsModel.h (modified) (1 diff)
• UIToolsView.cpp (modified) (1 diff)
• UIToolsView.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/manager/tools/UITools.cpp

@@ -157 +157 @@
     connect(m_pToolsModel, &UIToolsModel::sigItemMinimumHeightHintChanged,
             m_pToolsView, &UIToolsView::sltMinimumHeightHintChanged);
-    connect(m_pToolsModel, &UIToolsModel::sigFocusChanged,
-            m_pToolsView, &UIToolsView::sltFocusChanged);
 
     /* View connections: */
@@ -181 +179 @@
     disconnect(m_pToolsModel, &UIToolsModel::sigItemMinimumHeightHintChanged,
                m_pToolsView, &UIToolsView::sltMinimumHeightHintChanged);
-    disconnect(m_pToolsModel, &UIToolsModel::sigFocusChanged,
-               m_pToolsView, &UIToolsView::sltFocusChanged);
 
     /* View connections: */

trunk/src/VBox/Frontends/VirtualBox/src/manager/tools/UIToolsModel.cpp

@@ -222 +222 @@
     setFocusItem(currentItem());
 
-    /* Adjust corrresponding actions finally: */
+    /* Adjust corresponding actions finally: */
     const UIToolType enmType = currentItem() ? currentItem()->itemType() : UIToolType_Home;
     QMap<UIToolType, UIAction*> actions;
@@ -273 +273 @@
     if (m_pFocusItem)
         connect(m_pFocusItem.data(), &UIToolsItem::destroyed, this, &UIToolsModel::sltFocusItemDestroyed);
-
-    /* Notify about focus change: */
-    emit sigFocusChanged();
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/manager/tools/UIToolsModel.h

@@ -66 +66 @@
           * @param  enmType  Brings current tool type. */
         void sigSelectionChanged(UIToolType enmType);
-        /** Notifies about focus changed. */
-        void sigFocusChanged();
     /** @} */
 

trunk/src/VBox/Frontends/VirtualBox/src/manager/tools/UIToolsView.cpp

@@ -122 +122 @@
 {
     prepare();
-}
-
-void UIToolsView::sltFocusChanged()
-{
-    /* Make sure focus-item set: */
-    const UIToolsItem *pFocusItem = tools() && tools()->model()
-                                  ? tools()->model()->focusItem()
-                                  : 0;
-    if (!pFocusItem)
-        return;
-
-    const QSize viewSize = viewport()->size();
-    QRectF geo = pFocusItem->geometry();
-    geo &= QRectF(geo.topLeft(), viewSize);
-    ensureVisible(geo, 0, 0);
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/manager/tools/UIToolsView.h

@@ -62 +62 @@
 public slots:
 
-    /** @name General stuff.
-      * @{ */
-        /** Handles focus change to @a pFocusItem. */
-        void sltFocusChanged();
-    /** @} */
-
     /** @name Layout stuff.
       * @{ */