Changeset 108235 in vbox

Timestamp:

Feb 16, 2025 2:24:41 PM (2 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

167556

Message:

Runtime/RTAcpi*: Implement constant folding for ShiftLeft (used by vbox.dsl), bugref:10733 [build fix + memory leak fixes]

Location:

trunk/src/VBox/Runtime/common/acpi

Files:

• acpi-ast.cpp (modified) (1 diff)
• acpi-compiler.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/common/acpi/acpi-ast.cpp

@@ -87 +87 @@
 DECLHIDDEN(void) rtAcpiAstNodeFree(PRTACPIASTNODE pAstNd)
 {
-    /** @todo */
+    /* Free all the arguments first. */
+    for (uint8_t i = 0; i < pAstNd->cArgs; i++)
+    {
+        if (   pAstNd->aArgs[i].enmType == kAcpiAstArgType_AstNode
+            && pAstNd->aArgs[i].u.pAstNd)
+            rtAcpiAstNodeFree(pAstNd->aArgs[i].u.pAstNd);
+    }
+
+    if (pAstNd->fFlags & RTACPI_AST_NODE_F_NEW_SCOPE)
+    {
+        PRTACPIASTNODE pIt, pItNext;
+        /* Do transformations on the nodes first. */
+        RTListForEachSafe(&pAstNd->LstScopeNodes, pIt, pItNext, RTACPIASTNODE, NdAst)
+        {
+            RTListNodeRemove(&pIt->NdAst);
+            rtAcpiAstNodeFree(pIt);
+        }
+    }
+
+    pAstNd->enmOp  = kAcpiAstNodeOp_Invalid;
+    pAstNd->cArgs  = 0;
+    pAstNd->fFlags = 0;
     RTMemFree(pAstNd);
 }

trunk/src/VBox/Runtime/common/acpi/acpi-compiler.cpp

@@ -3019 +3019 @@
                     if (RT_SUCCESS(rc))
                     {
-                        pIt;
                         RTListForEach(&pThis->LstStmts, pIt, RTACPIASTNODE, NdAst)
                         {