Changeset 108361 in vbox

Timestamp:

Feb 24, 2025 6:09:03 PM (8 weeks ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

167721

Message:

Audio/DrvHostAudioWasApi: Two bugfixes for bugref:10844

• Check for the device status when looking for a cache hit and invalidate the entry if the device is not in active state (anymore)
• If the default device has been changed, also take the device role into account.

See comments for details.

File:

• trunk/src/VBox/Devices/Audio/DrvHostAudioWasApi.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Audio/DrvHostAudioWasApi.cpp

@@ -569 +569 @@
         if (    m_pDrvWas != NULL
             && (   (enmFlow == eRender  && !m_pDrvWas->pwszOutputDevId)
-                || (enmFlow == eCapture && !m_pDrvWas->pwszInputDevId)))
+                || (enmFlow == eCapture && !m_pDrvWas->pwszInputDevId))
+            /* We only care for the multimedia role of a device here.
+             * Devices can have multiple roles they expose interfaces for.
+             *
+             * Not having this check will result in several OnDefaultDeviceChanged calls
+             * with the same device ID but with a different role. However, in our audio stack there is no concept
+             * of a device role, so we try avoiding that by only caring about eMultimedia.
+             *
+             * See @bugref{10844} */
+            && (enmRole == eMultimedia)
+           )
         {
             pIEnumerator = m_pDrvWas->pIEnumerator;
@@ -1283 +1293 @@
                     && RTUtf16Cmp(pDevEntry->wszDevId, pwszDevId) == 0)
                 {
+                    /* First, try retrieving the current device state here as a yet another messure for
+                     * AUDCLNT_E_DEVICE_INVALIDATED errors.  See @bugref{10844} */
+                    DWORD dwState;
+                    hrc = pIDevice->GetState(&dwState);
+                    if (SUCCEEDED(hrc))
+                    {
+                        if (dwState != DEVICE_STATE_ACTIVE)
+                            LOG_STALE_DEVICE_BREAK(("WasAPI: Cache hit for device '%ls': Non-active state (state %#x)\n",
+                                                    pDevEntry->wszDevId, drvHostAudioWasMMDeviceStateToString(dwState)));
+                    }
+                    else
+                        LOG_STALE_DEVICE_BREAK(("WasAPI: Cache hit for device '%ls': Unable to retrieve state (hr=%#x)\n",
+                                                pDevEntry->wszDevId, hrc));
+
                     /*
                      * Cache hit -- here we now need to also check if the device interface we want to look up