Changeset 108515 in vbox for trunk/src/VBox/VMM

Timestamp:

Mar 11, 2025 9:06:04 AM (8 weeks ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

167905

Message:

VMM/GIC: bugref:10404 cleanup, spaces.

File:

• trunk/src/VBox/VMM/VMMR3/GICR3.cpp (modified) (7 diffs)

trunk/src/VBox/VMM/VMMR3/GICR3.cpp

@@ -76 +76 @@
 
 /**
- * Dumps basic APIC state.
+ * Dumps basic GIC state.
  *
  * @param   pVM         The cross context VM structure.
@@ -697 +697 @@
      * Init the data.
      */
-    pGic->pDevInsR3     = pDevIns;
+    pGic->pDevInsR3 = pDevIns;
 
     /*
@@ -720 +720 @@
     int rc = PDMDevHlpSetDeviceCritSect(pDevIns, PDMDevHlpCritSectGetNop(pDevIns));
     AssertRCReturn(rc, rc);
-#else
-    int rc;
 #endif
 
@@ -729 +727 @@
      *
      * Currently we only support GICv3. */
-    rc = pHlp->pfnCFGMQueryU8Def(pCfg, "ArchRev", &pGicDev->uArchRev, 3);
+    int rc = pHlp->pfnCFGMQueryU8Def(pCfg, "ArchRev", &pGicDev->uArchRev, 3);
     AssertLogRelRCReturn(rc, rc);
     if (pGicDev->uArchRev == 3)
@@ -855 +853 @@
                                 N_("Configuration error: Failed to get the \"RedistributorMmioBase\" value"));
 
-    RTGCPHYS cbRegion = (RTGCPHYS)pVM->cCpus * (GIC_REDIST_REG_FRAME_SIZE + GIC_REDIST_SGI_PPI_REG_FRAME_SIZE); /* Adjacent and per vCPU. */
+    RTGCPHYS const cbRegion = (RTGCPHYS)pVM->cCpus
+                            * (GIC_REDIST_REG_FRAME_SIZE + GIC_REDIST_SGI_PPI_REG_FRAME_SIZE); /* Adjacent and per vCPU. */
     rc = PDMDevHlpMmioCreateAndMap(pDevIns, GCPhysMmioBase, cbRegion, gicReDistMmioWrite, gicReDistMmioRead,
                                    IOMMMIO_FLAGS_READ_DWORD | IOMMMIO_FLAGS_WRITE_DWORD_ZEROED, "GIC_ReDist", &pGicDev->hMmioReDist);
@@ -890 +889 @@
     for (VMCPUID idCpu = 0; idCpu < pVM->cCpus; idCpu++)
     {
-        PVMCPU  pVCpu     = pVM->apCpusR3[idCpu];
-        PGICCPU pGicCpu  = VMCPU_TO_GICCPU(pVCpu);
+        PVMCPU  pVCpu   = pVM->apCpusR3[idCpu];
+        PGICCPU pGicCpu = VMCPU_TO_GICCPU(pVCpu);
 
         GIC_REG_COUNTER(&pGicCpu->StatMmioReadR3,    "%u/MmioRead",     "Number of MMIO reads in R3.");
@@ -909 +908 @@
 #endif
 
-
     gicR3Reset(pDevIns);
     return VINF_SUCCESS;