Changeset 108534 in vbox

Timestamp:

Mar 12, 2025 10:35:28 AM (2 months ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

167924

Message:

FE/Qt: bugref:10814: VBox Manager / Tools pane: Reordering code according to Global, Machines, Managers architecture.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/manager

Files:

• UIToolPane.cpp (modified) (4 diffs)
• UIToolPane.h (modified) (6 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/manager/UIToolPane.cpp

@@ -60 +60 @@
     , m_enmClass(enmClass)
     , m_pActionPool(pActionPool)
+    , m_fActive(false)
     , m_pLayout(0)
     , m_pPaneHome(0)
@@ -68 +69 @@
     , m_pPaneCloud(0)
     , m_pPaneActivities(0)
-    , m_fActive(false)
 {
     prepare();
@@ -491 +491 @@
 }
 
-void UIToolPane::setCloudMachineItems(const QList<UIVirtualMachineItemCloud*> &cloudItems)
-{
-    /* Cache passed value: */
-    m_cloudItems = cloudItems;
-
-    /* Update activity overview pane if it is open: */
-    if (isToolOpened(UIToolType_Activities))
-    {
-        AssertPtrReturnVoid(m_pPaneActivities);
-        m_pPaneActivities->setCloudMachineItems(m_cloudItems);
-    }
-}
-
 UIMachineToolsWidget *UIToolPane::machineToolsWidget() const
 {
@@ -562 +549 @@
 {
     return m_pPaneSnapshots ? m_pPaneSnapshots->currentSnapshotId() : QUuid();
+}
+
+void UIToolPane::setCloudMachineItems(const QList<UIVirtualMachineItemCloud*> &cloudItems)
+{
+    /* Cache passed value: */
+    m_cloudItems = cloudItems;
+
+    /* Update activity overview pane if it is open: */
+    if (isToolOpened(UIToolType_Activities))
+    {
+        AssertPtrReturnVoid(m_pPaneActivities);
+        m_pPaneActivities->setCloudMachineItems(m_cloudItems);
+    }
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/manager/UIToolPane.h

@@ -67 +67 @@
     /** @name Global tool stuff.
       * @{ */
-        /** Notifies listeners about creation procedure was requested. */
-        void sigCreateMedium();
-        /** Notifies listeners about copy procedure was requested for medium with specified @a uMediumId. */
-        void sigCopyMedium(const QUuid &uMediumId);
-
-        /** Notifies listeners about request to switch to Activity pane of machine with @a uMachineId. */
-        void sigSwitchToMachineActivityPane(const QUuid &uMachineId);
+        /** Notifies listeners about request to detach pane with tool type @enmToolType. */
+        void sigDetachToolPane(UIToolType enmToolType);
     /** @} */
 
@@ -90 +85 @@
         /** Notifies listeners about request to switch to Activity Overview pane. */
         void sigSwitchToActivityOverviewPane();
-
-        /** Notifies listeners about request to detach pane with tool type @enmToolType. */
-        void sigDetachToolPane(UIToolType enmToolType);
+    /** @} */
+
+    /** @name Manager tool stuff.
+      * @{ */
+        /** Notifies listeners about creation procedure was requested. */
+        void sigCreateMedium();
+        /** Notifies listeners about copy procedure was requested for medium with specified @a uMediumId. */
+        void sigCopyMedium(const QUuid &uMediumId);
+
+        /** Notifies listeners about request to switch to Activity pane of machine with @a uMachineId. */
+        void sigSwitchToMachineActivityPane(const QUuid &uMachineId);
     /** @} */
 
@@ -126 +129 @@
     /** @name Global tool stuff.
       * @{ */
+        /** Holds the Machine Tools Widget instance. */
+        UIMachineToolsWidget *machineToolsWidget() const;
+    /** @} */
+
+    /** @name Machine tool stuff.
+      * @{ */
+        /** Defines error @a strDetails and switches to Error pane. */
+        void setErrorDetails(const QString &strDetails);
+
+        /** Defines the machine @a items. */
+        void setItems(const QList<UIVirtualMachineItem*> &items);
+
+        /** Returns whether current-state item of Snapshot pane is selected. */
+        bool isCurrentStateItemSelected() const;
+        /** Returns currently selected snapshot ID if any. */
+        QUuid currentSnapshotId();
+    /** @} */
+
+    /** @name Manager tool stuff.
+      * @{ */
         /** Defines the @a cloudItems. */
         void setCloudMachineItems(const QList<UIVirtualMachineItemCloud*> &cloudItems);
-
-        /** Holds the Machine Tools Widget instance. */
-        UIMachineToolsWidget *machineToolsWidget() const;
-    /** @} */
-
-    /** @name Machine tool stuff.
-      * @{ */
-        /** Defines error @a strDetails and switches to Error pane. */
-        void setErrorDetails(const QString &strDetails);
-
-        /** Defines the machine @a items. */
-        void setItems(const QList<UIVirtualMachineItem*> &items);
-
-        /** Returns whether current-state item of Snapshot pane is selected. */
-        bool isCurrentStateItemSelected() const;
-
-        /** Returns currently selected snapshot ID if any. */
-        QUuid currentSnapshotId();
     /** @} */
 
 private slots:
 
-    /** @name Machine tool stuff.
+    /** @name Global tool stuff.
       * @{ */
         /** Handles the detach signals received from panes.*/
@@ -173 +178 @@
     UIActionPool *m_pActionPool;
 
+    /** Holds whether this pane is active. */
+    bool  m_fActive;
+
     /** Holds the stacked-layout instance. */
     QStackedLayout *m_pLayout;
 
-    /** Holds the Home pane instance. */
-    UIHomePane *m_pPaneHome;
-
-    /** @name Global tool stuff.
-      * @{ */
+    /** @name Global tool stuff.
+      * @{ */
+        /** Holds the Home pane instance. */
+        UIHomePane *m_pPaneHome;
+
         /** Holds the Machine Tools Widget instance. */
         UIMachineToolsWidget *m_pPaneMachines;
@@ -199 +207 @@
         /** Holds the File Manager pane instance. */
         UIFileManager          *m_pPaneFileManager;
-    /** @} */
-
-    /** @name Global tool stuff.
+
+        /** Holds the cache of passed machine items. */
+        QList<UIVirtualMachineItem*>  m_items;
+    /** @} */
+
+    /** @name Manager tool stuff.
       * @{ */
         /** Holds the Extension Pack Manager instance. */
@@ -213 +224 @@
         /** Holds the VM Activity Overview instance. */
         UIVMActivityOverviewWidget   *m_pPaneActivities;
-    /** @} */
-
-    /** Holds whether this pane is active. */
-    bool  m_fActive;
-
-    /** @name Global tool stuff.
-      * @{ */
+
         /** Holds the cache of passed cloud machine items. */
         QList<UIVirtualMachineItemCloud*>  m_cloudItems;
     /** @} */
-
-    /** @name Machine tool stuff.
-      * @{ */
-        /** Holds the cache of passed items. */
-        QList<UIVirtualMachineItem*>  m_items;
-    /** @} */
 };