Changeset 108567 in vbox

Timestamp:

Mar 17, 2025 10:48:45 AM (8 weeks ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

167972

Message:

FE/Qt: bugref:10867. Adding the medium size widget to the hardware page.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/wizards

Files:

• editors/UIWizardNewVMEditors.cpp (modified) (5 diffs)
• editors/UIWizardNewVMEditors.h (modified) (3 diffs)
• newvm/UIWizardNewVM.cpp (modified) (1 diff)
• newvm/UIWizardNewVMDiskPage.cpp (modified) (1 diff)
• newvm/UIWizardNewVMExpertPage.cpp (modified) (1 diff)
• newvm/UIWizardNewVMHardwarePage.cpp (modified) (7 diffs)
• newvm/UIWizardNewVMHardwarePage.h (modified) (3 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/wizards/editors/UIWizardNewVMEditors.cpp

@@ -36 +36 @@
 #include "UIFilePathSelector.h"
 #include "UIHostnameDomainNameEditor.h"
+#include "UIMediumSizeEditor.h"
 #include "UIMediumTools.h"
 #include "UITranslationEventListener.h"
@@ -323 +324 @@
 *********************************************************************************************************************************/
 
-UINewVMHardwareContainer::UINewVMHardwareContainer(QWidget *pParent /* = 0 */)
+UINewVMHardwareContainer::UINewVMHardwareContainer(QWidget *pParent, bool fWithMediumSizeEditor)
     : QWidget(pParent)
     , m_pBaseMemoryEditor(0)
     , m_pVirtualCPUEditor(0)
     , m_pEFICheckBox(0)
+    , m_pMediumSizeEditor(0)
+    , m_fWithMediumSizeEditor(fWithMediumSizeEditor)
 {
     prepare();
@@ -350 +353 @@
 }
 
+void UINewVMHardwareContainer::setMediumSize(qulonglong uSize)
+{
+    if (m_pMediumSizeEditor)
+        m_pMediumSizeEditor->setMediumSize(uSize);
+}
+
 void UINewVMHardwareContainer::prepare()
 {
@@ -357 +366 @@
     m_pBaseMemoryEditor = new UIBaseMemoryEditor;
     m_pVirtualCPUEditor = new UIVirtualCPUEditor;
+    if (m_fWithMediumSizeEditor)
+        m_pMediumSizeEditor = new UIMediumSizeEditor;
     m_pEFICheckBox      = new QCheckBox;
     pHardwareLayout->addWidget(m_pBaseMemoryEditor, 0, 0, 1, 4);
     pHardwareLayout->addWidget(m_pVirtualCPUEditor, 1, 0, 1, 4);
-    pHardwareLayout->addWidget(m_pEFICheckBox, 2, 0, 1, 1);
+    if (m_pMediumSizeEditor)
+    {
+        pHardwareLayout->addWidget(m_pMediumSizeEditor, 2, 0, 1, 4);
+        pHardwareLayout->addWidget(m_pEFICheckBox, 3, 0, 1, 1);
+    }
+    else
+        pHardwareLayout->addWidget(m_pEFICheckBox, 2, 0, 1, 1);
 
 
@@ -372 +389 @@
         connect(m_pEFICheckBox, &QCheckBox::toggled,
                 this, &UINewVMHardwareContainer::sigEFIEnabledChanged);
+    if (m_pMediumSizeEditor)
+        connect(m_pMediumSizeEditor, &UIMediumSizeEditor::sigSizeChanged,
+                this, &UINewVMHardwareContainer::sigSizeChanged);
 
     sltRetranslateUI();

trunk/src/VBox/Frontends/VirtualBox/src/wizards/editors/UIWizardNewVMEditors.h

@@ -45 +45 @@
 class UIHostnameDomainNameEditor;
 class UIPasswordLineEdit;
+class UIMediumSizeEditor;
 class UIUserNamePasswordEditor;
 class UIVirtualCPUEditor;
@@ -166 +167 @@
     void sigCPUCountChanged(int iCount);
     void sigEFIEnabledChanged(bool fEnabled);
-
-public:
-
-    UINewVMHardwareContainer(QWidget *pParent = 0);
-
-    /** @name Wrappers for UIFilePathSelector
+    void sigSizeChanged(qulonglong uSize);
+
+public:
+
+    UINewVMHardwareContainer(QWidget *pParent, bool fWithMediumSizeEditor);
+
+    /** @name Wrappers for members
       * @{ */
         void setMemorySize(int iSize);
         void setCPUCount(int iCount);
         void setEFIEnabled(bool fEnabled);
+        void setMediumSize(qulonglong uSize);
     /** @} */
 
@@ -192 +195 @@
     UIVirtualCPUEditor *m_pVirtualCPUEditor;
     QCheckBox *m_pEFICheckBox;
+    UIMediumSizeEditor *m_pMediumSizeEditor;
+    bool m_fWithMediumSizeEditor;
 };
 

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvm/UIWizardNewVM.cpp

@@ -114 +114 @@
             setUnattendedPageVisible(false);
             addPage(new UIWizardNewVMHardwarePage("create-vm-wizard-hardware" /* help keyword*/));
-            addPage(new UIWizardNewVMDiskPage(m_pActionPool, "create-vm-wizard-virtual-hard-disk" /* help keyword*/));
             addPage(new UIWizardNewVMSummaryPage);
             break;

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvm/UIWizardNewVMDiskPage.cpp

@@ -201 +201 @@
     }
 
-    /* Initialize medium variant parameter of the wizard (only if user has not touched the checkbox yet): */
-    if (!m_userModifiedParameters.contains("MediumVariant"))
-    {
-        pWizard->setMediumVariant((qulonglong)KMediumVariant_Standard);
-    }
+    pWizard->setMediumVariant((qulonglong)KMediumVariant_Standard);
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvm/UIWizardNewVMExpertPage.cpp

@@ -81 +81 @@
         m_pToolBox->insertPage(ExpertToolboxItems_NameAndOSType, createNameOSTypeWidgets(), "");
         m_pToolBox->insertPage(ExpertToolboxItems_Unattended, createUnattendedWidgets(), "");
-        m_pHardwareWidgetContainer = new UINewVMHardwareContainer;
+        m_pHardwareWidgetContainer = new UINewVMHardwareContainer(this, false /* without medium size editor */);
         m_pToolBox->insertPage(ExpertToolboxItems_Hardware, m_pHardwareWidgetContainer, "");
         m_pToolBox->insertPage(ExpertToolboxItems_Disk, createDiskWidgets(), "");

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvm/UIWizardNewVMHardwarePage.cpp

@@ -32 +32 @@
 #include "QIRichTextLabel.h"
 #include "UIBaseMemoryEditor.h"
+#include "UIWizardDiskEditors.h"
 #include "UIGlobalSession.h"
 #include "UIGuestOSType.h"
@@ -39 +40 @@
 #include "UIWizardNewVMHardwarePage.h"
 
+/* COM includes: */
+#include "CSystemProperties.h"
 
 UIWizardNewVMHardwarePage::UIWizardNewVMHardwarePage(const QString strHelpKeyword /* = QString() */)
@@ -44 +47 @@
     , m_pLabel(0)
     , m_pHardwareWidgetContainer(0)
+    , m_fVDIFormatFound(false)
+    , m_uMediumSizeMin(_4M)
+    , m_uMediumSizeMax(gpGlobalSession->virtualBox().GetSystemProperties().GetInfoVDSize())
 {
     prepare();
@@ -55 +61 @@
     m_pLabel = new QIRichTextLabel(this);
     pMainLayout->addWidget(m_pLabel);
-    m_pHardwareWidgetContainer = new UINewVMHardwareContainer;
+    m_pHardwareWidgetContainer = new UINewVMHardwareContainer(this, true /* with medium size editor */);
     AssertReturnVoid(m_pHardwareWidgetContainer);
     pMainLayout->addWidget(m_pHardwareWidgetContainer);
@@ -73 +79 @@
         connect(m_pHardwareWidgetContainer, &UINewVMHardwareContainer::sigEFIEnabledChanged,
                 this, &UIWizardNewVMHardwarePage::sltEFIEnabledChanged);
+        connect(m_pHardwareWidgetContainer, &UINewVMHardwareContainer::sigSizeChanged,
+                this, &UIWizardNewVMHardwarePage::sltHandleSizeEditorChange);
     }
 }
@@ -114 +122 @@
         m_pHardwareWidgetContainer->blockSignals(false);
     }
+    initializeVirtualHardDiskParameters();
+}
+
+void UIWizardNewVMHardwarePage::initializeVirtualHardDiskParameters()
+{
+    UIWizardNewVM *pWizard = wizardWindow<UIWizardNewVM>();
+    AssertReturnVoid(pWizard);
+
+    LONG64 iRecommendedSize = 0;
+
+    if (!m_userModifiedParameters.contains("SelectedDiskSource"))
+    {
+        iRecommendedSize = gpGlobalSession->guestOSTypeManager().getRecommendedHDD(pWizard->guestOSTypeId());
+        if (iRecommendedSize != 0)
+        {
+            pWizard->setDiskSource(SelectedDiskSource_New);
+            pWizard->setEmptyDiskRecommended(false);
+        }
+        else
+        {
+            pWizard->setDiskSource(SelectedDiskSource_Empty);
+            pWizard->setEmptyDiskRecommended(true);
+        }
+    }
+
+    if (!m_fVDIFormatFound)
+    {
+        /* We do not have any UI elements for HDD format selection since we default to VDI in case of guided wizard mode: */
+        CSystemProperties properties = gpGlobalSession->virtualBox().GetSystemProperties();
+        const QVector<CMediumFormat> &formats = properties.GetMediumFormats();
+        foreach (const CMediumFormat &format, formats)
+        {
+            if (format.GetName() == "VDI")
+            {
+                pWizard->setMediumFormat(format);
+                m_fVDIFormatFound = true;
+            }
+        }
+        if (!m_fVDIFormatFound)
+            AssertMsgFailed(("No medium format corresponding to VDI could be found!"));
+    }
+    QString strDefaultExtension =  UIWizardDiskEditors::defaultExtension(pWizard->mediumFormat(), KDeviceType_HardDisk);
+
+    /* We set the medium name and path according to machine name/path and do not allow user change these in the guided mode: */
+    QString strDefaultName = pWizard->machineFileName().isEmpty() ? QString("NewVirtualDisk1") : pWizard->machineFileName();
+    const QString &strMachineFolder = pWizard->machineFolder();
+    QString strMediumPath =
+        UIWizardDiskEditors::constructMediumFilePath(UIWizardDiskEditors::appendExtension(strDefaultName,
+                                                                                          strDefaultExtension), strMachineFolder);
+    pWizard->setMediumPath(strMediumPath);
+
+    /* Set the recommended disk size if user has already not done so: */
+    if (m_pHardwareWidgetContainer && !m_userModifiedParameters.contains("MediumSize"))
+    {
+        m_pHardwareWidgetContainer->blockSignals(true);
+        m_pHardwareWidgetContainer->setMediumSize(iRecommendedSize);
+        m_pHardwareWidgetContainer->blockSignals(false);
+        pWizard->setMediumSize(iRecommendedSize);
+    }
+
+    pWizard->setMediumVariant((qulonglong)KMediumVariant_Standard);
 }
 
 bool UIWizardNewVMHardwarePage::isComplete() const
 {
-    return true;
+   UIWizardNewVM *pWizard = wizardWindow<UIWizardNewVM>();
+   AssertReturn(pWizard, false);
+
+   const qulonglong uSize = pWizard->mediumSize();
+   if (pWizard->diskSource() == SelectedDiskSource_New)
+       return uSize >= m_uMediumSizeMin && uSize <= m_uMediumSizeMax;
+   return true;
 }
 
@@ -141 +216 @@
     m_userModifiedParameters << "EFIEnabled";
 }
+
+void UIWizardNewVMHardwarePage::sltHandleSizeEditorChange(qulonglong uSize)
+{
+    AssertReturnVoid(wizardWindow<UIWizardNewVM>());
+    wizardWindow<UIWizardNewVM>()->setMediumSize(uSize);
+    m_userModifiedParameters << "MediumSize";
+    emit completeChanged();
+}

trunk/src/VBox/Frontends/VirtualBox/src/wizards/newvm/UIWizardNewVMHardwarePage.h

@@ -55 +55 @@
     void sltCPUCountChanged(int iCount);
     void sltEFIEnabledChanged(bool fEnabled);
+    void sltHandleSizeEditorChange(qulonglong uSize);
     virtual void sltRetranslateUI() RT_OVERRIDE RT_FINAL;
 
@@ -64 +65 @@
     virtual void initializePage() RT_OVERRIDE RT_FINAL;
     virtual bool isComplete() const RT_OVERRIDE RT_FINAL;
-
+    void initializeVirtualHardDiskParameters();
     /** @name Widgets
       * @{ */
@@ -70 +71 @@
         UINewVMHardwareContainer *m_pHardwareWidgetContainer;
     /** @} */
+    bool m_fVDIFormatFound;
+    qulonglong m_uMediumSizeMin;
+    qulonglong m_uMediumSizeMax;
     /** This set is used to decide if we have to set wizard's parameters
       * some default values or not. When user modifies a value through a widget we