Changeset 108872 in vbox

Timestamp:

Apr 7, 2025 1:48:00 PM (13 days ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

168322

Message:

VMM/GIC: bugref:10877 GIC ITS command-queue, work-in-progress.

File:

• trunk/src/VBox/VMM/VMMAll/GITSAll.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMAll/GITSAll.cpp

@@ -549 +549 @@
             }
 
-            /* Indicate to the guest we've fetched all commands. */
-            GITS_CRIT_SECT_ENTER(pDevIns);
-            pGitsDev->uCmdReadReg = RT_BF_SET(pGitsDev->uCmdReadReg, GITS_BF_CTRL_REG_CREADR_OFFSET, offWrite);
-
             /*
              * Process the commands in the buffer.
@@ -558 +554 @@
             if (RT_SUCCESS(rc))
             {
-                /* Don't hold the lock while processing commands. */
+                /* Indicate to the guest we've fetched all commands. */
+                GITS_CRIT_SECT_ENTER(pDevIns);
+                pGitsDev->uCmdReadReg = RT_BF_SET(pGitsDev->uCmdReadReg, GITS_BF_CTRL_REG_CREADR_OFFSET, offWrite);
+
+                /* Don't hold the critical section while processing commands. */
                 GITS_CRIT_SECT_LEAVE(pDevIns);
 
-                uint32_t const cCmds = cbCmds / GITS_CMD_SIZE;
+                uint32_t const cCmds = cbCmds / sizeof(GITSCMD);
                 for (uint32_t idxCmd = 0; idxCmd < cCmds; idxCmd++)
                 {
-                    PCGITSCMD pCmd = (PCGITSCMD)((uintptr_t)pvBuf + (idxCmd * GITS_CMD_SIZE));
+                    PCGITSCMD pCmd = (PCGITSCMD)((uintptr_t)pvBuf + (idxCmd * sizeof(GITSCMD)));
                     uint8_t const uCmdId = pCmd->common.uCmdId;
                     switch (uCmdId)