Changeset 108877 in vbox for trunk/src/VBox/VMM/VMMAll

Timestamp:

Apr 8, 2025 7:42:07 AM (4 weeks ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

168328

Message:

VMM/GIC: bugref:10877 GITS command-queue, work-in-progress.

File:

• trunk/src/VBox/VMM/VMMAll/GITSAll.cpp (modified) (5 diffs)

trunk/src/VBox/VMM/VMMAll/GITSAll.cpp

@@ -65 +65 @@
 #define GITS_CRIT_SECT_IS_OWNER(a_pDevIns)      PDMDevHlpCritSectIsOwner((a_pDevIns), (a_pDevIns)->CTX_SUFF(pCritSectRo))
 
+/** GITS diagnostic enum description expansion.
+ * The below construct ensures typos in the input to this macro are caught
+ * during compile time. */
+#define GITSDIAG_DESC(a_Name)        RT_CONCAT(kGitsDiag_, a_Name) < kGitsDiag_End ? RT_STR(a_Name) : "Ignored"
+
 
 /*********************************************************************************************************************************
@@ -81 +86 @@
 AssertCompileSize(GITSITE, 8);
 
-/** GITS diagnostic enum description expansion.
- * The below construct ensures typos in the input to this macro are caught
- * during compile time. */
-#define GITSDIAG_DESC(a_Name)        RT_CONCAT(kGitsDiag_, a_Name) < kGitsDiag_End ? RT_STR(a_Name) : "Ignored"
+
+/*********************************************************************************************************************************
+*   Global Variables                                                                                                             *
+*********************************************************************************************************************************/
 /** GITS diagnostics description for members in GITSDIAG. */
 static const char *const g_apszGitsDiagDesc[] =
@@ -94 +99 @@
 AssertCompile(RT_ELEMENTS(g_apszGitsDiagDesc) == kGitsDiag_End);
 #undef GITSDIAG_DESC
-
-
-/*********************************************************************************************************************************
-*   Global Variables                                                                                                             *
-*********************************************************************************************************************************/
 
 
@@ -420 +420 @@
     pGitsDev->uCmdReadReg        = 0;
     pGitsDev->uCmdWriteReg       = 0;
+    RT_ZERO(pGitsDev->auCt);
 }
 
@@ -571 +572 @@
                         {
                             Assert(!RT_BF_GET(pGitsDev->uTypeReg.u, GITS_BF_CTRL_REG_TYPER_PTA)); /* GITS_TYPER is read-only */
-                            /** @todo Implementing me. Figure out interrupt collection, HCC etc. */
-                            //uint64_t const uDw2 = pCmd->au64[2].u;
-                            //bool const     fValid            = RT_BF_GET(uDw2, GITS_BF_CMD_MAPC_DW2_VALID);
-                            //uint32_t const uTargetCpuId      = RT_BF_GET(uDw2, GITS_BF_CMD_MAPC_DW2_RDBASE);
-                            //uint16_t const uIntrCollectionId = RT_BF_GET(uDw2, GITS_BF_CMD_MAPC_DW2_IC_ID);
+                            uint64_t const uDw2 = pCmd->au64[2].u;
+                            bool const     fValid            = RT_BF_GET(uDw2, GITS_BF_CMD_MAPC_DW2_VALID);
+                            uint32_t const uTargetCpuId      = RT_BF_GET(uDw2, GITS_BF_CMD_MAPC_DW2_RDBASE);
+                            uint16_t const uIntrCollectionId = RT_BF_GET(uDw2, GITS_BF_CMD_MAPC_DW2_IC_ID);
+
+                            AssertRelease(uIntrCollectionId < RT_ELEMENTS(pGitsDev->auCt));
+                            pGitsDev->auCt[uIntrCollectionId].fValid      = fValid;
+                            pGitsDev->auCt[uIntrCollectionId].idTargetCpu = uTargetCpuId;
+                            break;
+                        }
+
+                        case GITS_CMD_ID_SYNC:
+                        {
+                            /* Nothing to do since all previous commands have committed their changes to device state. */
+                            break;
+                        }
+
+                        case GITS_CMD_ID_INVALL:
+                        {
+                            /* Nothing to do as we currently do not cache interrupt mappings. */
                             break;
                         }