Changeset 108918 in vbox

Timestamp:

Apr 9, 2025 12:32:57 PM (11 days ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

168401

Message:

VMM/GIC: bugref:10877 GIC ITS, initialize type and size of ITS table (DTE or ITE?) as read-only bits.

File:

• trunk/src/VBox/VMM/VMMAll/GITSAll.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMAll/GITSAll.cpp

@@ -316 +316 @@
         {
             if (cb == 8)
-                pGitsDev->aItsTableRegs[idxReg].u = uValue;
+                pGitsDev->aItsTableRegs[idxReg].u = uValue & GITS_CTRL_REG_BASER_RW_MASK;
             else
-                pGitsDev->aItsTableRegs[idxReg].s.Lo = uValue;
+                pGitsDev->aItsTableRegs[idxReg].s.Lo = uValue & RT_LO_U32(GITS_CTRL_REG_BASER_RW_MASK);
         }
         else
         {
             Assert(cb == 4);
-            pGitsDev->aItsTableRegs[idxReg].s.Hi = uValue;
+            pGitsDev->aItsTableRegs[idxReg].s.Hi = uValue & RT_HI_U32(GITS_CTRL_REG_BASER_RW_MASK);
         }
         return;
@@ -411 +411 @@
     Assert(RT_ELEMENTS(pGitsDev->auCtes) >= RT_BF_GET(pGitsDev->uTypeReg.u, GITS_BF_CTRL_REG_TYPER_HCC));
     RT_ZERO(pGitsDev->aItsTableRegs);
-    //pGitsDev->aItsTableRegs[0].u = RT_BF_MAKE(GITS_BF_CTRL_REG_BASER_ENTRY_SIZE, )
-
-    pGitsDev->uCmdBaseReg.u = 0;
-    pGitsDev->uCmdReadReg   = 0;
-    pGitsDev->uCmdWriteReg  = 0;
+
+    pGitsDev->aItsTableRegs[0].u = RT_BF_MAKE(GITS_BF_CTRL_REG_BASER_ENTRY_SIZE, GITS_ITE_SIZE - 1)
+                                 | RT_BF_MAKE(GITS_BF_CTRL_REG_BASER_TYPE,       GITS_BASER_TYPE_DEVICES)
+                                 | RT_BF_MAKE(GITS_BF_CTRL_REG_BASER_VALID,      1);
+
+    pGitsDev->uCmdBaseReg.u   = 0;
+    pGitsDev->uCmdReadReg     = 0;
+    pGitsDev->uCmdWriteReg    = 0;
     RT_ZERO(pGitsDev->auCtes);