Changeset 10999 in vbox for trunk/src/VBox/Frontends

Timestamp:

Jul 30, 2008 4:44:26 PM (16 years ago)

Author:

vboxsync

Message:

Fe/Qt4: Latest cumulative update for defect #3000:
Little changes to VDM's API & it's callers.
Fixing bug when it was not possible to directly select HD image for attachment through VDM (which invoked from VM Settings / HD Page).
Fixing bug when the action to invoke VDM for selected HD attachment was available to be triggered (crash) if clean-item selected.
Fixing bug with unable to focus separate HD attachment when navigating with keyboard after clearing SATA attachments.

Location:

trunk/src/VBox/Frontends/VirtualBox4

Files:

• include/VBoxDiskImageManagerDlg.h (modified) (1 diff)
• include/VBoxVMSettingsHD.h (modified) (1 diff)
• src/VBoxConsoleWnd.cpp (modified) (2 diffs)
• src/VBoxDiskImageManagerDlg.cpp (modified) (2 diffs)
• src/VBoxVMFirstRunWzd.cpp (modified) (1 diff)
• src/VBoxVMSettingsCD.cpp (modified) (1 diff)
• src/VBoxVMSettingsFD.cpp (modified) (1 diff)
• src/VBoxVMSettingsHD.cpp (modified) (8 diffs)

trunk/src/VBox/Frontends/VirtualBox4/include/VBoxDiskImageManagerDlg.h

@@ -49 +49 @@
     VBoxDiskImageManagerDlg (QWidget *aParent = NULL, Qt::WindowFlags aFlags = Qt::Dialog);
 
-    void setup (int aType, bool aDoSelect, const QUuid *aTargetVMId = NULL, bool aRefresh = true, CMachine aMachine = NULL, const QUuid & aHdId = QUuid(), const QUuid & aCdId = QUuid(), const QUuid & aFdId = QUuid());
+    void setup (int aType, bool aDoSelect, const QUuid &aTargetVMId = QUuid(), bool aRefresh = true, CMachine aMachine = NULL, const QUuid &aHdId = QUuid(), const QUuid &aCdId = QUuid(), const QUuid &aFdId = QUuid());
 
     static void showModeless (bool aRefresh = true);

trunk/src/VBox/Frontends/VirtualBox4/include/VBoxVMSettingsHD.h

@@ -287 +287 @@
 signals:
 
+    void signalToCloseEditor (QWidget *aEditor,
+                              QAbstractItemDelegate::EndEditHint aCloseHint);
     void hdChanged();
 

trunk/src/VBox/Frontends/VirtualBox4/src/VBoxConsoleWnd.cpp

@@ -2578 +2578 @@
 
     VBoxDiskImageManagerDlg dlg (this);
-    QUuid id = csession.GetMachine().GetId();
-    dlg.setup (VBoxDefs::FD, true, &id);
+    dlg.setup (VBoxDefs::FD, true, csession.GetMachine().GetId());
 
     if (dlg.exec() == QDialog::Accepted)
@@ -2622 +2621 @@
 
     VBoxDiskImageManagerDlg dlg (this);
-    QUuid id = csession.GetMachine().GetId();
-    dlg.setup (VBoxDefs::CD, true, &id);
+    dlg.setup (VBoxDefs::CD, true, csession.GetMachine().GetId());
 
     if (dlg.exec() == QDialog::Accepted)

trunk/src/VBox/Frontends/VirtualBox4/src/VBoxDiskImageManagerDlg.cpp

@@ -447 +447 @@
 
 void VBoxDiskImageManagerDlg::setup (int aType, bool aDoSelect,
-                                     const QUuid *aTargetVMId /* = NULL */,
+                                     const QUuid &aTargetVMId /* = NULL */,
                                      bool aRefresh /* = true */,
                                      CMachine aMachine /* = NULL */,
@@ -465 +465 @@
 
     mDoSelect = aDoSelect;
-    if (aTargetVMId)
-        mTargetVMId = *aTargetVMId;
+    if (!aTargetVMId.isNull())
+        mTargetVMId = aTargetVMId;
 
     if (mDoSelect)

trunk/src/VBox/Frontends/VirtualBox4/src/VBoxVMFirstRunWzd.cpp

@@ -242 +242 @@
 {
     VBoxDiskImageManagerDlg vdm (this);
-    QUuid machineId = mMachine.GetId();
     VBoxDefs::DiskType type = mRbCdType->isChecked() ? VBoxDefs::CD :
         mRbFdType->isChecked() ? VBoxDefs::FD : VBoxDefs::InvalidType;
-    vdm.setup (type, true, &machineId);
+    vdm.setup (type, true, mMachine.GetId());
     if (vdm.exec() == QDialog::Accepted)
     {

trunk/src/VBox/Frontends/VirtualBox4/src/VBoxVMSettingsCD.cpp

@@ -248 +248 @@
     QUuid oldId = mUuidIsoCD;
     VBoxDiskImageManagerDlg dlg (this);
-    QUuid machineId = mMachine.GetId();
-    dlg.setup (VBoxDefs::CD, true, &machineId, true /* aRefresh */,
+    dlg.setup (VBoxDefs::CD, true, mMachine.GetId(), true /* aRefresh */,
                mMachine, QUuid(), mCbIsoCD->getId(), QUuid());
 

trunk/src/VBox/Frontends/VirtualBox4/src/VBoxVMSettingsFD.cpp

@@ -244 +244 @@
     QUuid oldId = mUuidIsoFD;
     VBoxDiskImageManagerDlg dlg (this);
-    QUuid machineId = mMachine.GetId();
-    dlg.setup (VBoxDefs::FD, true, &machineId, true /* aRefresh */,
+    dlg.setup (VBoxDefs::FD, true, mMachine.GetId(), true /* aRefresh */,
                mMachine, QUuid(), mCbIsoFD->getId(), QUuid());
 

trunk/src/VBox/Frontends/VirtualBox4/src/VBoxVMSettingsHD.cpp

@@ -260 +260 @@
     : VBoxMediaComboBox (aParent, VBoxDefs::HD)
 {
+    mInstance = this;
     setBelongsTo (HDSlotUniquizer::instance()->machine().GetId());
     connect (this, SIGNAL (currentIndexChanged (int)), this, SLOT (onActivate()));
@@ -265 +266 @@
              parent()->parent(), SLOT (commitData (QWidget *)));
     refresh();
-    mInstance = this;
 }
 HDVdiEditor::~HDVdiEditor()
 {
-    mInstance = 0;
+    if (mInstance == this)
+        mInstance = 0;
 }
 
@@ -468 +469 @@
              SIGNAL (mediaRemoved (VBoxDefs::DiskType, const QUuid &)),
              this, SLOT (onMediaRemoved (VBoxDefs::DiskType, const QUuid &)));
+    connect (this, SIGNAL (signalToCloseEditor (QWidget*, QAbstractItemDelegate::EndEditHint)),
+             mTwAts, SLOT (closeEditor (QWidget*, QAbstractItemDelegate::EndEditHint)));
 
     /* Install global event filter */
@@ -650 +653 @@
         if (result == QIMessageBox::Yes)
         {
-            mTwAts->closePersistentEditor (mTwAts->currentIndex());
+            /* Close the editor to avoid it's infliction to data model */
+            emit signalToCloseEditor (HDVdiEditor::activeEditor(),
+                                      QAbstractItemDelegate::NoHint);
+
+            /* Run new HD wizard */
             VBoxNewHDWzd dlg (this);
             if (dlg.exec() == QDialog::Accepted)
@@ -703 +710 @@
     Assert (mTwAts->currentIndex().isValid());
 
+    /* Close the editor to avoid it's infliction to data model */
+    emit signalToCloseEditor (HDVdiEditor::activeEditor(),
+                              QAbstractItemDelegate::NoHint);
+
+    HDVdiValue oldVdi (mModel->data (mTwAts->currentIndex(), Qt::EditRole)
+                       .value<HDVdiValue>());
+
     VBoxDiskImageManagerDlg dlg (this);
-    QUuid machineId = mMachine.GetId();
-    HDVdiValue vdiInfo (mModel->data (mTwAts->currentIndex(), Qt::EditRole)
-                        .value<HDVdiValue>());
-    QUuid hdId = vdiInfo.id;
-    dlg.setup (VBoxDefs::HD, true, &machineId, true, mMachine, hdId);
+    dlg.setup (VBoxDefs::HD, true, mMachine.GetId(), true, mMachine, oldVdi.id);
 
     if (dlg.exec() == QDialog::Accepted)
     {
+        /* Compose resulting vdi */
         QVariant result;
-        HDVdiValue val (VBoxMediaComboBox::fullItemName (dlg.selectedPath()),
-                        dlg.selectedUuid());
-        result.setValue (val);
+        HDVdiValue newVdi (VBoxMediaComboBox::fullItemName (dlg.selectedPath()),
+                           dlg.selectedUuid());
+        result.setValue (newVdi);
+
+        /* Set the model's data */
         mModel->setData (mTwAts->currentIndex(), result);
     }
@@ -722 +735 @@
 }
 
-void VBoxVMSettingsHD::onCurrentChanged (const QModelIndex &aIndex)
+void VBoxVMSettingsHD::onCurrentChanged (const QModelIndex& /* aIndex */)
 {
     mNewAction->setEnabled (mModel->rowCount() - 1 <
         HDSlotUniquizer::instance()->list (HDSltValue(), false).count());
     mDelAction->setEnabled (mTwAts->currentIndex().row() != mModel->rowCount() - 1);
-    mVdmAction->setEnabled (aIndex.isValid() && aIndex.column() == 1);
+    mVdmAction->setEnabled (mTwAts->currentIndex().row() != mModel->rowCount() - 1 &&
+                            mTwAts->currentIndex().column() == 1);
 }
 
@@ -744 +758 @@
         if (firstSataPort < list.size())
         {
-            int rc = vboxProblem().confirmDetachSATASlots (this);
-            if (rc != QIMessageBox::Ok)
+            if (vboxProblem().confirmDetachSATASlots (this) != QIMessageBox::Ok)
             {
                 /* Switch check-box back to "Qt::Checked" */
@@ -757 +770 @@
                 /* Delete SATA items */
                 mModel->removeSata();
+
+                /* Set column #1 of first index to be the current */
+                mTwAts->setCurrentIndex (mModel->index (0, 1));
+
                 if (mValidator)
                     mValidator->revalidate();