Changeset 11038 in vbox for trunk/src/VBox/Runtime/common/checksum

Timestamp:

Jul 31, 2008 5:20:59 PM (17 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

33933

Message:

iprt/RTNetIPv4: The checksums are in network endian, corrected the validators.

File:

• trunk/src/VBox/Runtime/common/checksum/ipv4.cpp (modified) (7 diffs)

trunk/src/VBox/Runtime/common/checksum/ipv4.cpp

@@ -40 +40 @@
  * Calculates the checksum of the IPv4 header.
  *
- * @returns Checksum.
+ * @returns Checksum (network endian).
  * @param   pIpHdr      Pointer to the IPv4 header to checksum, network endian (big).
  *                      Assumes the caller already checked the minimum size requirement.
@@ -120 +120 @@
      */
     uint16_t u16Sum = RTNetIPv4HdrChecksum(pIpHdr);
-    if (RT_UNLIKELY(RT_BE2H_U16(pIpHdr->ip_sum) != u16Sum))
+    if (RT_UNLIKELY(pIpHdr->ip_sum != u16Sum))
         return false;
     return true;
@@ -348 +348 @@
  * Finalizes a IPv4 checksum [inlined].
  *
- * @returns The checksum.
+ * @returns The checksum (network endian).
  * @param   u32Sum          The 32-bit intermediate checksum value.
  */
@@ -363 +363 @@
  * Finalizes a IPv4 checksum.
  *
- * @returns The checksum.
+ * @returns The checksum (network endian).
  * @param   u32Sum          The 32-bit intermediate checksum value.
  */
@@ -370 +370 @@
     return rtNetIPv4FinalizeChecksum(u32Sum);
 }
-
 
 
@@ -377 +376 @@
  * UDP header and payload.
  *
- * @returns The checksum.
+ * @returns The checksum (network endian).
  * @param   pIpHdr          Pointer to the IPv4 header, in network endian (big).
  * @param   pUdpHdr         Pointer to the UDP header, in network endian (big).
@@ -450 +449 @@
         return false;
     uint16_t u16Sum = RTNetIPv4UDPChecksum(pIpHdr, pUdpHdr, pvData);
-    if (RT_UNLIKELY(RT_BE2H_U16(pUdpHdr->uh_sum) != u16Sum))
+    if (RT_UNLIKELY(pUdpHdr->uh_sum != u16Sum))
         return false;
     return true;
 }
+
+