Changeset 11597 in vbox

Timestamp:

Aug 23, 2008 11:33:52 PM (16 years ago)

Author:

vboxsync

Message:

iprt: RTR3Init is called more than once (IPC and now nspr init), so do proper reference counting.

File:

• trunk/src/VBox/Runtime/r3/init.cpp (modified) (5 diffs)

trunk/src/VBox/Runtime/r3/init.cpp

@@ -64 +64 @@
 *   Global Variables                                                           *
 *******************************************************************************/
+/** The number of calls to RTR3Init. */
+static int32_t volatile g_cUsers = 0;
+/** Whether we're currently initializing the IPRT. */
+static bool volatile    g_fInitializing = false;
+
 /** Program path.
  * The size is hardcoded, so we'll have to check for overflow when setting it
@@ -115 +120 @@
     /* no entry log flow, because prefixes and thread may freak out. */
 
+    /*
+     * Do reference counting, only initialize the first time around.
+     * 
+     * We are ASSUMING that nobody will be able to race RTR3Init calls when the 
+     * first one, the real init, is running (second assertion).
+     */
+    int32_t cUsers = ASMAtomicIncS32(&g_cUsers);
+    if (cUsers != 1)
+    {
+        AssertMsg(cUsers > 1, ("%d\n", cUsers));
+        Assert(!g_fInitializing);
+#if !defined(IN_GUEST) && !defined(RT_NO_GIP)
+        if (fInitSUPLib)
+            SUPInit(NULL, cbReserve);
+#endif 
+    }
+    ASMAtomicWriteBool(&g_fInitializing, true);
+
 #if !defined(IN_GUEST) && !defined(RT_NO_GIP)
 # ifdef VBOX
@@ -142 +165 @@
     {
         AssertMsgFailed(("Failed to get executable directory path, rc=%d!\n", rc));
+        ASMAtomicWriteBool(&g_fInitializing, false);
+        ASMAtomicDecS32(&g_cUsers);
         return rc;
     }
@@ -187 +212 @@
     {
         AssertMsgFailed(("Failed to get executable directory path, rc=%d!\n", rc));
+        ASMAtomicWriteBool(&g_fInitializing, false);
+        ASMAtomicDecS32(&g_cUsers);
         return rc;
     }
@@ -204 +231 @@
 
     LogFlow(("RTR3Init: returns VINF_SUCCESS\n"));
+    ASMAtomicWriteBool(&g_fInitializing, false);
     return VINF_SUCCESS;
 }