Changeset 1189 in vbox

Timestamp:

Mar 4, 2007 8:34:10 PM (18 years ago)

Author:

vboxsync

Message:

Corrected bug in the multiple release event semaphore wait code. Added a todo for a scheduling race condition on smp boxes.

File:

• trunk/src/VBox/Runtime/r0drv/darwin/semaphore-r0drv-darwin.cpp (modified) (2 diffs)

trunk/src/VBox/Runtime/r0drv/darwin/semaphore-r0drv-darwin.cpp

@@ -185 +185 @@
         ASMAtomicIncU32(&pEventInt->cWaking);
         thread_wakeup_prim((event_t)pEventInt, TRUE /* one thread */, THREAD_AWAKENED);
+        /** @todo this isn't safe. a scheduling interrupt on the other cpu while we're in here
+         * could cause the thread to be timed out before we manage to wake it up and the event
+         * ends up in the wrong state. ditto for posix signals. */
     }
     else
@@ -405 +408 @@
     int rc;
     if (pEventMultiInt->fSignaled)
-    {
-        ASMAtomicXchgU8(&pEventMultiInt->fSignaled, false);
         rc = VINF_SUCCESS;
-    }
     else
     {