Changeset 11966 in vbox for trunk

Timestamp:

Sep 2, 2008 10:00:59 AM (16 years ago)

Author:

vboxsync

Message:

Solaris/vboxdrv: fixed reboot issue with vboxnetflt and vboxdrv.

File:

• trunk/src/VBox/HostDrivers/Support/solaris/SUPDrv-solaris.c (modified) (4 diffs)

trunk/src/VBox/HostDrivers/Support/solaris/SUPDrv-solaris.c

@@ -201 +201 @@
         LogRel((DEVICE_NAME ":failed to disable autounloading!\n"));
 
-    int rc = ddi_soft_state_init(&g_pVBoxDrvSolarisState, sizeof(vbox_devstate_t), 8);
-    if (!rc)
-    {
-        rc = mod_install(&g_VBoxDrvSolarisModLinkage);
-        if (!rc)
-            return 0; /* success */
-
-        ddi_soft_state_fini(&g_pVBoxDrvSolarisState);
-        LogRel((DEVICE_NAME ":mod_install failed! rc=%d\n", rc));
+    /*
+     * Initialize IPRT R0 driver, which internally calls OS-specific r0 init.
+     */
+    int rc = RTR0Init(0);
+    if (RT_SUCCESS(rc))
+    {
+        /*
+         * Initialize the device extension
+         */
+        rc = supdrvInitDevExt(&g_DevExt);
+        if (RT_SUCCESS(rc))
+        {
+            /*
+             * Initialize the session hash table.
+             */
+            memset(g_apSessionHashTab, 0, sizeof(g_apSessionHashTab));
+            rc = RTSpinlockCreate(&g_Spinlock);
+            if (RT_SUCCESS(rc))
+            {
+                int rc = ddi_soft_state_init(&g_pVBoxDrvSolarisState, sizeof(vbox_devstate_t), 8);
+                if (!rc)
+                {
+                    rc = mod_install(&g_VBoxDrvSolarisModLinkage);
+                    if (!rc)
+                        return 0; /* success */
+
+                    ddi_soft_state_fini(&g_pVBoxDrvSolarisState);
+                    LogRel((DEVICE_NAME ":mod_install failed! rc=%d\n", rc));
+                }
+                else
+                    LogRel((DEVICE_NAME ":failed to initialize soft state.\n"));
+
+                RTSpinlockDestroy(g_Spinlock);
+                g_Spinlock = NIL_RTSPINLOCK;
+            }
+            else
+                LogRel((DEVICE_NAME ":VBoxDrvSolarisAttach: RTSpinlockCreate failed\n"));
+            supdrvDeleteDevExt(&g_DevExt);
+        }
+        else
+            LogRel((DEVICE_NAME ":VBoxDrvSolarisAttach: supdrvInitDevExt failed\n"));
+        RTR0Term();
     }
     else
-        LogRel((DEVICE_NAME ":failed to initialize soft state.\n"));
-
-    return rc;
+        LogRel((DEVICE_NAME ":VBoxDrvSolarisAttach: failed to init R0Drv\n"));
+    memset(&g_DevExt, 0, sizeof(g_DevExt));
+
+    return -1;
 }
 
@@ -222 +256 @@
     LogFlow((DEVICE_NAME ":_fini\n"));
 
-    int e = mod_remove(&g_VBoxDrvSolarisModLinkage);
-    if (e != 0)
-        return e;
+    /*
+     * Undo the work we did at start (in the reverse order).
+     */
+    int rc = mod_remove(&g_VBoxDrvSolarisModLinkage);
+    if (rc != 0)
+        return rc;
+
+    supdrvDeleteDevExt(&g_DevExt);
+
+    rc = RTSpinlockDestroy(g_Spinlock);
+    AssertRC(rc);
+    g_Spinlock = NIL_RTSPINLOCK;
+
+    RTR0Term();
+
+    memset(&g_DevExt, 0, sizeof(g_DevExt));
 
     ddi_soft_state_fini(&g_pVBoxDrvSolarisState);
-    return e;
+    return 0;
 }
 
@@ -270 +317 @@
 
             /*
-             * Initialize IPRT R0 driver, which internally calls OS-specific r0 init.
+             * Register ourselves as a character device, pseudo-driver
              */
-            rc = RTR0Init(0);
-            if (RT_SUCCESS(rc))
+#ifdef VBOX_WITH_HARDENING
+            rc = ddi_create_priv_minor_node(pDip, DEVICE_NAME, S_IFCHR, instance, DDI_PSEUDO,
+                                            0, "all", "all", 0600);
+#else
+            rc = ddi_create_priv_minor_node(pDip, DEVICE_NAME, S_IFCHR, instance, DDI_PSEUDO,
+                                            0, "none", "none", 0666);
+#endif
+            if (rc == DDI_SUCCESS)
             {
-                /*
-                 * Initialize the device extension
-                 */
-                rc = supdrvInitDevExt(&g_DevExt);
-                if (RT_SUCCESS(rc))
-                {
-                    /*
-                     * Initialize the session hash table.
-                     */
-                    memset(g_apSessionHashTab, 0, sizeof(g_apSessionHashTab));
-                    rc = RTSpinlockCreate(&g_Spinlock);
-                    if (RT_SUCCESS(rc))
-                    {
-                        /*
-                         * Register ourselves as a character device, pseudo-driver
-                         */
-#ifdef VBOX_WITH_HARDENING
-                        rc = ddi_create_priv_minor_node(pDip, DEVICE_NAME, S_IFCHR, instance, DDI_PSEUDO,
-                                                        0, "all", "all", 0600);
-#else
-                        rc = ddi_create_priv_minor_node(pDip, DEVICE_NAME, S_IFCHR, instance, DDI_PSEUDO,
-                                                        0, "none", "none", 0666);
+#ifdef USE_SESSION_HASH
+                pState->pDip = pDip;
 #endif
-                        if (rc == DDI_SUCCESS)
-                        {
-#ifdef USE_SESSION_HASH
-                            pState->pDip = pDip;
-#endif
-                            ddi_report_dev(pDip);
-                            return DDI_SUCCESS;
-                        }
-
-                        /* Is this really necessary? */
-                        ddi_remove_minor_node(pDip, NULL);
-                        LogRel((DEVICE_NAME ":VBoxDrvSolarisAttach: ddi_create_priv_minor_node failed.\n"));
-
-                        RTSpinlockDestroy(g_Spinlock);
-                        g_Spinlock = NIL_RTSPINLOCK;
-                    }
-                    else
-                        LogRel((DEVICE_NAME ":VBoxDrvSolarisAttach: RTSpinlockCreate failed\n"));
-                    supdrvDeleteDevExt(&g_DevExt);
-                }
-                else
-                    LogRel((DEVICE_NAME ":VBoxDrvSolarisAttach: supdrvInitDevExt failed\n"));
-                RTR0Term();
+                ddi_report_dev(pDip);
+                return DDI_SUCCESS;
             }
-            else
-                LogRel((DEVICE_NAME ":VBoxDrvSolarisAttach: failed to init R0Drv\n"));
-            memset(&g_DevExt, 0, sizeof(g_DevExt));
-            break;
+            
+            return DDI_FAILURE;
         }
 
@@ -371 +381 @@
             ddi_soft_state_free(g_pVBoxDrvSolarisState, instance);
 #endif
-
-            supdrvDeleteDevExt(&g_DevExt);
-
-            rc = RTSpinlockDestroy(g_Spinlock);
-            AssertRC(rc);
-            g_Spinlock = NIL_RTSPINLOCK;
-
-            RTR0Term();
-
-            memset(&g_DevExt, 0, sizeof(g_DevExt));
             return DDI_SUCCESS;
         }