Changeset 12143 in vbox for trunk/src/VBox/Devices/Storage

Timestamp:

Sep 5, 2008 3:57:39 PM (16 years ago)

Author:

vboxsync

Message:

disk: ixed a bunch of NULL pointer accesses

Location:

trunk/src/VBox/Devices/Storage

Files:

• RawHDDCore.cpp (modified) (1 diff)
• VBoxHDD-new.cpp (modified) (7 diffs)
• VDIHDDCore.cpp (modified) (1 diff)
• VHDHDDCore.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Storage/RawHDDCore.cpp

@@ -396 +396 @@
     {
         pCbProgress = VDGetInterfaceProgress(pIfProgress);
-        pfnProgress = pCbProgress->pfnProgress;
+        if (pCbProgress)
+            pfnProgress = pCbProgress->pfnProgress;
         pvUser = pIfProgress->pvUser;
     }

trunk/src/VBox/Devices/Storage/VBoxHDD-new.cpp

@@ -1506 +1506 @@
     }
 
-    if (RT_SUCCESS(rc) && pCbProgress->pfnProgress)
+    if (RT_SUCCESS(rc) && pCbProgress && pCbProgress->pfnProgress)
         pCbProgress->pfnProgress(NULL /* WARNING! pVM=NULL */, 100,
                                  pIfProgress->pvUser);
@@ -1701 +1701 @@
     }
 
-    if (RT_SUCCESS(rc) && pCbProgress->pfnProgress)
+    if (RT_SUCCESS(rc) && pCbProgress && pCbProgress->pfnProgress)
         pCbProgress->pfnProgress(NULL /* WARNING! pVM=NULL */, 100,
                                  pIfProgress->pvUser);
@@ -1827 +1827 @@
                 cbRemaining -= cbThisRead;
 
-                if (pCbProgress->pfnProgress)
+                if (pCbProgress && pCbProgress->pfnProgress)
                 {
                     rc = pCbProgress->pfnProgress(NULL /* WARNING! pVM=NULL */,
@@ -1876 +1876 @@
                 cbRemaining -= cbThisRead;
 
-                if (pCbProgress->pfnProgress)
+                if (pCbProgress && pCbProgress->pfnProgress)
                 {
                     rc = pCbProgress->pfnProgress(NULL /* WARNING! pVM=NULL */,
@@ -1944 +1944 @@
         RTMemTmpFree(pvBuf);
 
-    if (RT_SUCCESS(rc) && pCbProgress->pfnProgress)
+    if (RT_SUCCESS(rc) && pCbProgress && pCbProgress->pfnProgress)
         pCbProgress->pfnProgress(NULL /* WARNING! pVM=NULL */, 100,
                                  pIfProgress->pvUser);
@@ -2148 +2148 @@
             cbRemaining -= cbThisRead;
 
-            if (pCbProgress->pfnProgress)
+            if (pCbProgress && pCbProgress->pfnProgress)
             {
                 rc = pCbProgress->pfnProgress(NULL /* WARNING! pVM=NULL */,
@@ -2213 +2213 @@
     if (RT_SUCCESS(rc))
     {
-        if (pCbProgress->pfnProgress)
+        if (pCbProgress && pCbProgress->pfnProgress)
             pCbProgress->pfnProgress(NULL /* WARNING! pVM=NULL */, 100,
                                      pIfProgress->pvUser);

trunk/src/VBox/Devices/Storage/VDIHDDCore.cpp

@@ -834 +834 @@
     {
         pCbProgress = VDGetInterfaceProgress(pIfProgress);
-        pfnProgress = pCbProgress->pfnProgress;
+        if (pCbProgress)
+            pfnProgress = pCbProgress->pfnProgress;
         pvUser = pIfProgress->pvUser;
     }

trunk/src/VBox/Devices/Storage/VHDHDDCore.cpp

@@ -1600 +1600 @@
     {
         pCbProgress = VDGetInterfaceProgress(pIfProgress);
-        pfnProgress = pCbProgress->pfnProgress;
+        if (pCbProgress)
+            pfnProgress = pCbProgress->pfnProgress;
         pvUser = pIfProgress->pvUser;
     }