Changeset 12384 in vbox

Timestamp:

Sep 10, 2008 11:56:43 PM (16 years ago)

Author:

vboxsync

Message:

DrvHostSerial: review.

File:

• trunk/src/VBox/Devices/Serial/DrvHostSerial.cpp (modified) (8 diffs)

trunk/src/VBox/Devices/Serial/DrvHostSerial.cpp

@@ -75 +75 @@
 /** Size of the send fifo queue (in bytes) */
 #ifdef RT_OS_DARWIN
+  /** @todo This is really desperate, but it seriously looks like
+   * the data is arriving way too fast for us to push over. 9600
+   * baud and zoc reports sending at 12000+ chars/sec... */
 # define CHAR_MAX_SEND_QUEUE             0x400
 # define CHAR_MAX_SEND_QUEUE_MASK        0x3ff
@@ -113 +116 @@
     RTFILE                      DeviceFile;
 # ifdef RT_OS_DARWIN
-    /** The device handle used for reading. */
+    /** The device handle used for reading.
+     * Used to prevent the read selecto from blocking the writes. */
     RTFILE                      DeviceFileR;
 # endif
@@ -473 +477 @@
 
 #ifdef RT_OS_WINDOWS
-    /* Make sure that the halt event sempahore is resetted. */
+    /* Make sure that the halt event semaphore is reset. */
     DWORD dwRet = WaitForSingleObject(pThis->hHaltEventSem, 0);
 
@@ -575 +579 @@
             }
 
-#endif
+#endif /* RT_OS_WINDOWS */
             if (RT_FAILURE(rc))
             {
@@ -690 +694 @@
 
 #ifdef RT_OS_WINDOWS
-    /* Make sure that the halt event sempahore is resetted. */
+    /* Make sure that the halt event semaphore is reset. */
     DWORD dwRet = WaitForSingleObject(pThis->hHaltEventSem, 0);
 
@@ -1007 +1011 @@
 }
 
-
 # ifdef RT_OS_LINUX
 /** Signal handler for SIGUSR2.
@@ -1016 +1019 @@
     return;
 }
-# endif
+# endif /* RT_OS_LINUX */
 
 /**
@@ -1425 +1428 @@
     if (pThis->DeviceFileR != NIL_RTFILE)
     {
-        if (pThis->DeviceFile != pThis->DeviceFileR)
+        if (pThis->DeviceFileR != pThis->DeviceFile)
         {
             int rc = RTFileClose(pThis->DeviceFileR);