Changeset 12460 in vbox

Timestamp:

Sep 15, 2008 12:15:17 PM (16 years ago)

Author:

vboxsync

Message:

Proper exit paths in case of failure.

File:

• trunk/src/VBox/Main/win/PerformanceWin.cpp (modified) (10 diffs)

trunk/src/VBox/Main/win/PerformanceWin.cpp

@@ -332 +332 @@
         {
             Log (("Failed to read 'IDProcess' property. HR = %x\n", hr));
-            return VERR_INTERNAL_ERROR;
+            rc = VERR_INTERNAL_ERROR;
+            break;
         }
         LogFlowThisFunc (("Matching process %x against the list of machines...\n", dwIDProcess));
@@ -345 +346 @@
             {
                 Log (("Failed to read 'PercentUserTime' property. HR = %x\n", hr));
-                    return VERR_INTERNAL_ERROR;
+                rc = VERR_INTERNAL_ERROR;
+                break;
             }
             if (FAILED (hr = apEnumAccess[i]->ReadQWORD(
@@ -352 +354 @@
             {
                 Log (("Failed to read 'PercentPrivilegedTime' property. HR = %x\n", hr));
-                    return VERR_INTERNAL_ERROR;
+                rc = VERR_INTERNAL_ERROR;
+                break;
             }
             if (FAILED (hr = apEnumAccess[i]->ReadQWORD(
@@ -359 +362 @@
             {
                 Log (("Failed to read 'Timestamp_Sys100NS' property. HR = %x\n", hr));
-                    return VERR_INTERNAL_ERROR;
+                rc = VERR_INTERNAL_ERROR;
+                break;
             }
             if (FAILED (hr = apEnumAccess[i]->ReadQWORD(
@@ -366 +370 @@
             {
                 Log (("Failed to read 'WorkingSet' property. HR = %x\n", hr));
-                    return VERR_INTERNAL_ERROR;
+                rc = VERR_INTERNAL_ERROR;
+                break;
             }
 
@@ -373 +378 @@
             rc = VINF_SUCCESS;
         }
+    }
+
+    for (unsigned i = 0; i < dwNumReturned; i++)
+    {
         apEnumAccess[i]->Release();
         apEnumAccess[i] = NULL;
@@ -412 +421 @@
         {
             Log (("Failed to read 'Name' property. HR = %x\n", hr));
-            return VERR_INTERNAL_ERROR;
+            rc = VERR_INTERNAL_ERROR;
+            break;
         }
         if (wcscmp(tmpBuf, L"_Total") == 0)
@@ -420 +430 @@
                 user)))
             {
-            Log (("Failed to read 'PercentUserTime' property. HR = %x\n", hr));
-                return VERR_INTERNAL_ERROR;
+                Log (("Failed to read 'PercentUserTime' property. HR = %x\n", hr));
+                rc = VERR_INTERNAL_ERROR;
+                break;
             }
             if (FAILED (hr = apEnumAccess[i]->ReadQWORD(
@@ -427 +438 @@
                 kernel)))
             {
-            Log (("Failed to read 'PercentPrivilegedTime' property. HR = %x\n", hr));
-                return VERR_INTERNAL_ERROR;
+                Log (("Failed to read 'PercentPrivilegedTime' property. HR = %x\n", hr));
+                rc = VERR_INTERNAL_ERROR;
+                break;
             }
             if (FAILED (hr = apEnumAccess[i]->ReadQWORD(
@@ -434 +446 @@
                 idle)))
             {
-            Log (("Failed to read 'PercentProcessorTime' property. HR = %x\n", hr));
-                return VERR_INTERNAL_ERROR;
+                Log (("Failed to read 'PercentProcessorTime' property. HR = %x\n", hr));
+                rc = VERR_INTERNAL_ERROR;
+                break;
             }
             rc = VINF_SUCCESS;
         }
+    }
+    for (unsigned i = 0; i < dwNumReturned; i++)
+    {
         apEnumAccess[i]->Release();
         apEnumAccess[i] = NULL;